Skip to content

Commit

Permalink
remove unneeded TODO- the compile command step already runs in the ma…
Browse files Browse the repository at this point in the history
…ke phase
  • Loading branch information
the-argus committed Aug 25, 2024
1 parent c183c94 commit c61a489
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions compile_commands.zig
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,7 @@ pub fn extractIncludeDirsFromCompileStep(b: *std.Build, step: *std.Build.Step.Co
var dirs_as_strings = std.ArrayList([]const u8).init(b.allocator);
defer dirs_as_strings.deinit();

// resolve lazy paths here
// TODO: should lazy paths be resolved later? it says to only use the
// function during the make phase so it seems possible that compile commands
// would get built before paths are resolved and then stuff doesn't work
// resolve lazy paths all at once
for (dirs.items) |lazy_path| {
dirs_as_strings.append(lazy_path.getPath(b)) catch @panic("OOM");
}
Expand Down

0 comments on commit c61a489

Please sign in to comment.