Ar sm add list filter form #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arandel1
requested review from
fullybaked,
nathanejbrown,
mindyzwan,
EmmaBin and
MarcosPerez16
|
Visit the preview URL for this PR (updated for commit 09f2d77): https://tcl-76-smart-shopping-list--pr23-ar-sm-add-list-filte-og3ncsb4.web.app (expires Sat, 07 Sep 2024 22:27:21 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 512b1a88be8ae05fd3e727b99332819df760271d |
EmmaBin
approved these changes
Aug 29, 2024
MarcosPerez16
approved these changes
Sep 1, 2024
There was a problem hiding this comment.
Pulled the most recent code for this issue and tested the filter. Everything works and great job with the implementation. I had seen that there was two useEffects but that was already covered and fixed. Great job guys! I like the fact that the filter works regardless of whether I type in upper or lower case.
nathanejbrown
approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
User can now search for items in their shopping list by searching part of the word or list item. The list displayed is an unfiltered list, and it filters once the user begins typing in the input. The user can use the Clear button to clear the input box.
Related Issue
closes 7
Acceptance Criteria
[x] The form includes the following elements List view, above the shopping list
[x] A text field (with semantic !) which narrows down the list as the user types
When there’s text in the field, some kind of button (e.g., an X) to clear the field. When the field is cleared, the list is reset to its unfiltered state.
Type of Changes
featureenhancementUpdates
Before
After
Testing Steps / QA Criteria
Visit branch and have a list ready, type letters in the input, and matching words should display, and the clear button should clear the input and the unfiltered list should display.