DON-998: set PI just before processing the payment instead of at the #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
time of creating the donation DON-998 - set exception class
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1151 +/- ##
===========================================
- Coverage 74.79% 74.28% -0.52%
===========================================
Files 128 128
Lines 5531 5588 +57
===========================================
+ Hits 4137 4151 +14
- Misses 1394 1437 +43 ☔ View full report in Codecov by Sentry. |
NoelLH
reviewed
Dec 27, 2024
| /** | ||
| * We only set Payment Intent on the day of the payment due to stripe limitations, see | ||
| */ | ||
| public function findDonationsToSetPaymentIntent(\DateTimeImmutable $atDateTime, int $limit): array |
There was a problem hiding this comment.
This seems to have no test coverage – would be a good fit for an integration test?
added 6 commits
December 27, 2024 16:38
…r time extent of retries
dorota-joanna
force-pushed
the
DON-998-2nd-3rd-donation-PI-rework
branch
2 times, most recently
from
6557795 to
eac45cd
Compare
…ady worked around
* create test mandate and optionally pass when creating test donation * stack all em persisits right before flush * assert donations not empty and match by uuid * add return type to set payment intent method * adding var_dump made it all actually pass
* inline amounts * use charity's salesforceID from parent
* remove 'missing salesforceId' exeptions, it will never be null
dorota-joanna
force-pushed
the
DON-998-2nd-3rd-donation-PI-rework
branch
from
563c2ed to
913327a
Compare
bdsl
reviewed
Jan 3, 2025
bdsl
reviewed
Jan 3, 2025
bdsl
reviewed
Jan 3, 2025
bdsl
reviewed
Jan 3, 2025
bdsl
reviewed
Jan 3, 2025
bdsl
reviewed
Jan 3, 2025
dorota-joanna
force-pushed
the
DON-998-2nd-3rd-donation-PI-rework
branch
from
95d34c4 to
06be75c
Compare
dorota-joanna
force-pushed
the
DON-998-2nd-3rd-donation-PI-rework
branch
from
72b9593 to
ea92c8a
Compare
dorota-joanna
force-pushed
the
DON-998-2nd-3rd-donation-PI-rework
branch
from
fad099c to
da7ac4f
Compare
bdsl
reviewed
Jan 8, 2025
dorota-joanna
force-pushed
the
DON-998-2nd-3rd-donation-PI-rework
branch
from
8e6bbb1 to
410d03d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
time of creating the donation