Swap order of _inner and identity cleanup #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenbrix
reviewed
Jun 7, 2024
stevenbrix
approved these changes
Jun 7, 2024
jumhyn-browser
commented
Jun 7, 2024
|
@jumhyn-browser I think the build failure may be due to a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen a couple of instances of what looks like overrelease/memory corruption when subclassing across the WinRT bridge. It seems like swapping the order of the deinitialization here has an effect. I don't totally understand the model here so cc @stevenbrix to help explain