Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap order of _inner and identity cleanup #168

Merged
merged 3 commits into from
Jun 7, 2024
Merged

Swap order of _inner and identity cleanup #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4fc562
Swap order of _inner and identity cleanup
jumhyn-browser Jun 7, 2024
fe9fdfa
elaborate on comment
jumhyn-browser Jun 7, 2024
299a320
pin gha-setup-swift
jumhyn-browser Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/windows-build/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ runs:
arch: amd64

- name: Install private Swift toolchain
uses: compnerd/gha-setup-swift@main
uses: compnerd/gha-setup-swift@81f383b35a86e6e966de139be25b451d4f7dd953
with:
github-repo: thebrowsercompany/swift-build
github-token: ${{ inputs.GITHUB_TOKEN }}
Expand Down
7 changes: 4 additions & 3 deletions swiftwinrt/Resources/Support/WinRTProtocols.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,11 @@ open class WinRTClass : CustomQueryInterface, Equatable {
}

deinit {
// ensure we release the identity pointer before releasing _inner. releasing the _inner
// cleans up the underlying COM object.
identity = nil
// ensure we release the _inner pointer before releasing identity. releasing the _inner
// cleans up the underlying COM object, which might be holding a reference to the identity pointer.

_inner = nil
identity = nil
}
}

Expand Down
Loading