Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write iasync info #83

Merged
merged 6 commits into from
Aug 17, 2023
Merged

write iasync info #83

merged 6 commits into from
Aug 17, 2023

Conversation

stevenbrix
Copy link
Collaborator

@stevenbrix stevenbrix commented Aug 16, 2023

IAsyncInfo is a special interface with it's own header file (much like IInspectable). This nuance makes it annoying to work with and so before we just didn't try writing the type.

Changes

  1. remove include of AsyncInfo.h and remove special checks for the type so that we can let our code-gen do it's thing

Fixes WIN-103

@stevenbrix stevenbrix requested a review from a team as a code owner August 16, 2023 23:24
@linear
Copy link

linear bot commented Aug 16, 2023

WIN-103 Write IAsyncInfo

IAsyncInfo is a manually written type. We don't generate wrappers for it and therefore can't implement it yet in swift

@stevenbrix stevenbrix requested a review from jeffdav August 16, 2023 23:24
@stevenbrix
Copy link
Collaborator Author

Just realizing this approach with the checked in hand written file might be silly and can just let the c code generator generate the definitions for these types

@tristanlabelle
Copy link
Contributor

Just realizing this approach with the checked in hand written file might be silly and can just let the c code generator generate the definitions for these types

If there's nothing preventing that, it would be a better approach. I'm surprised it would require so much special-casing.

@stevenbrix
Copy link
Collaborator Author

Just realizing this approach with the checked in hand written file might be silly and can just let the c code generator generate the definitions for these types

If there's nothing preventing that, it would be a better approach. I'm surprised it would require so much special-casing.

@tristanlabelle nope! nothing preventing it, latest update removed the handwritten version

swiftwinrt/file_writers.h Outdated Show resolved Hide resolved
swiftwinrt/main.cpp Outdated Show resolved Hide resolved
@stevenbrix stevenbrix merged commit b15bca8 into main Aug 17, 2023
@stevenbrix stevenbrix deleted the steve/iasync-info branch August 17, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants