Update schema.json with latest changes #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use '@next' as the default version otherwise '--no-top-ref' is treated as the id.
jessicamcinchak
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Thanks for this one!
We'll test this on next publish, and if it fixes #127 I'll rollback the original find&replace attempt in the Github workflow.
This PR also helped me understand your original questions and I hadn't realised the generated @next schema & examples on main had fallen out of sync with the type definitions - currently that's a bit too easy to forget to run manually when opening PRs so now proposing it's added to pre-commit hook here too which should help keep this much tidier and more aligned in future #132
| @@ -7,7 +7,7 @@ | |||
| "build": "pnpm build-schema:dist && pnpm build-json-examples", | |||
| "build-json-examples": "pnpm ts-node scripts/build-json-examples.ts", | |||
| "build-schema:dev": "pnpm ts-json-schema-generator --path 'types/**/*.ts' --out 'schema/schema.json' --type Schema --id @next --no-top-ref", | |||
| "build-schema:dist": "pnpm ts-json-schema-generator --path 'types/**/*.ts' --out 'schema/schema.json' --type Schema --id $VERSION --no-top-ref", | |||
| "build-schema:dist": "pnpm ts-json-schema-generator --path 'types/**/*.ts' --out 'schema/schema.json' --type Schema --id \"${VERSION:-@next}\" --no-top-ref", | |||
There was a problem hiding this comment.
Makes sense - thanks for this fix !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.