chore: add steps to pre-commit hook to build json examples & dev schema #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixeltrix
approved these changes
Mar 5, 2024
pixeltrix
approved these changes
Mar 5, 2024
jessicamcinchak
deleted the
jess/build-examples-and-schema-precommit-hook
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our examples & schema are correct in
dist& in/examples/dataonmain, but the generated examples and schema.json onmaincan fall out of sync with CI tests still passing if you simply forget to run either of these commands manually before pushing your changes (see #131) - too easy to forget & causing confusion with consumers!This adds
pnpm build-json-examples&pnpm build-schema:devcommands to the pre-commit hook if the branch is notmain. This should keep all files on main tagged at the@nextversion, and not impact the Github Actions workflow for publishing frommaintodistwith a correct published version number.