Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add steps to pre-commit hook to build json examples & dev schema #132

Merged
merged 4 commits into from
Mar 5, 2024
Merged

chore: add steps to pre-commit hook to build json examples & dev schema #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
33687f4
add commit hook to build examples and schema
jessicamcinchak Mar 5, 2024
d2c7b4d
add precommit commands
jessicamcinchak Mar 5, 2024
e024081
don't run extra precommit steps if branch is main
jessicamcinchak Mar 5, 2024
36d910b
tidy husky formatting
jessicamcinchak Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

branch="$(git rev-parse --abbrev-ref HEAD)"
if [ "$branch" != "main" ]; then
pnpm build-json-examples && pnpm build-schema:dev
fi

pnpm check && pnpm fix
git add .
51 changes: 46 additions & 5 deletions examples/validLawfulDevelopmentCertificateExisting.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,10 @@
{
"name": "Whole District excluding the Town of Chesham - Poultry production.",
"description": "Bucks County Council Town and Country Planning Act 1947 Town and Country Planning General Development Order 1950. Re Whole District excluding the Town of Chesham. In relation to poultry production.",
"source": "https://www.planning.data.gov.uk/entity/7010002192"
"source": {
"text": "Planning Data",
"url": "https://www.planning.data.gov.uk/entity/7010002192"
}
}
]
},
Expand Down Expand Up @@ -307,7 +310,7 @@
"intersects": false
},
{
"value": "designated.SPA",
"value": "nature.SPA",
"description": "Special Protection Area (SPA)",
"intersects": false
},
Expand All @@ -328,7 +331,10 @@
"entities": [
{
"name": "Chilterns",
"source": "https://www.planning.data.gov.uk/entity/1000005"
"source": {
"text": "Planning Data",
"url": "https://www.planning.data.gov.uk/entity/1000005"
}
}
]
},
Expand Down Expand Up @@ -367,7 +373,7 @@
"proposal": {
"projectType": [
{
"value": "extend.outbuildings.studio",
"value": "extend.outbuilding.studio",
"description": "Add an outbuilding - studio"
}
],
Expand Down Expand Up @@ -1854,7 +1860,42 @@
"source": "PlanX",
"service": {
"flowId": "824628b2-deeb-48b0-92b1-2ca7f3b17163",
"url": "https://www.editor.planx.dev/buckinghamshire/apply-for-a-lawful-development-certificate/preview"
"url": "https://www.editor.planx.dev/buckinghamshire/apply-for-a-lawful-development-certificate/preview",
"files": {
"required": [
{
"value": "photographs.proposed",
"description": "Photographs - proposed"
},
{
"value": "sitePlan.proposed",
"description": "Site plan - proposed"
},
{
"value": "elevations.proposed",
"description": "Elevations - proposed"
},
{
"value": "floorPlan.proposed",
"description": "Floor plan - proposed"
},
{
"value": "floorPlan.proposed",
"description": "Floor plan - proposed"
}
],
"recommended": [
{
"value": "otherEvidence",
"description": "Other - evidence or correspondence"
},
{
"value": "constructionInvoice",
"description": "Construction invoice"
}
],
"optional": []
}
},
"submittedAt": "2023-10-02t00:00:00z",
"schema": "https://theopensystemslab.github.io/digital-planning-data-schemas/@next/schema.json"
Expand Down
42 changes: 40 additions & 2 deletions examples/validLawfulDevelopmentCertificateProposed.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@
"intersects": false
},
{
"value": "designated.SPA",
"value": "nature.SPA",
"description": "Special Protection Area (SPA)",
"intersects": false
},
Expand Down Expand Up @@ -1216,7 +1216,45 @@
"source": "PlanX",
"service": {
"flowId": "824628b2-deeb-48b0-92b1-2ca7f3b17163",
"url": "https://www.editor.planx.dev/buckinghamshire/apply-for-a-lawful-development-certificate/preview"
"url": "https://www.editor.planx.dev/buckinghamshire/apply-for-a-lawful-development-certificate/preview",
"files": {
"required": [
{
"value": "roofPlan.existing",
"description": "Roof plan - existing"
},
{
"value": "sitePlan.existing",
"description": "Site plan - existing"
},
{
"value": "roofPlan.proposed",
"description": "Roof plan - proposed"
},
{
"value": "sitePlan.proposed",
"description": "Site plan - proposed"
},
{
"value": "elevations.existing",
"description": "Elevations - existing"
},
{
"value": "floorPlan.existing",
"description": "Floor plan - existing"
},
{
"value": "elevations.proposed",
"description": "Elevations - proposed"
},
{
"value": "floorPlan.proposed",
"description": "Floor plan - proposed"
}
],
"recommended": [],
"optional": []
}
},
"submittedAt": "2023-10-02T00:00:00+01:00",
"schema": "https://theopensystemslab.github.io/digital-planning-data-schemas/@next/schema.json"
Expand Down
43 changes: 41 additions & 2 deletions examples/validPlanningPermission.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@
"intersects": false
},
{
"value": "designated.SPA",
"value": "nature.SPA",
"description": "Special Protection Area (SPA)",
"intersects": false
},
Expand Down Expand Up @@ -1765,7 +1765,46 @@
"source": "PlanX",
"service": {
"flowId": "01e38c5d-e701-4e44-acdc-4d6b5cc3b854",
"url": "https://www.editor.planx.dev/lambeth/apply-for-planning-permission/preview"
"url": "https://www.editor.planx.dev/lambeth/apply-for-planning-permission/preview",
"files": {
"required": [
{
"value": "roofPlan.existing",
"description": "Roof plan - existing"
},
{
"value": "roofPlan.proposed",
"description": "Roof plan - proposed"
},
{
"value": "sitePlan.existing",
"description": "Site plan - existing"
},
{
"value": "sitePlan.proposed",
"description": "Site plan - proposed"
},
{
"value": "elevations.existing",
"description": "Elevations - existing"
},
{
"value": "elevations.proposed",
"description": "Elevations - proposed"
}
],
"recommended": [
{
"value": "floorPlan.existing",
"description": "Floor plan - existing"
},
{
"value": "floorPlan.proposed",
"description": "Floor plan - proposed"
}
],
"optional": []
}
},
"submittedAt": "2023-10-02T00:00:00.00Z",
"schema": "https://theopensystemslab.github.io/digital-planning-data-schemas/@next/schema.json"
Expand Down
44 changes: 37 additions & 7 deletions examples/validPriorApproval.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,27 +131,42 @@
{
"name": "Central Activities Zone",
"description": "Change of use from offices to dwelling houses is restricted",
"source": "https://www.planning.data.gov.uk/entity/7010000942"
"source": {
"text": "Planning Data",
"url": "https://www.planning.data.gov.uk/entity/7010000942"
}
},
{
"name": "Central Activities Zone",
"description": "Demolition of commercial buildings and construction of new dwellinghouses is restricted",
"source": "https://www.planning.data.gov.uk/entity/7010000944"
"source": {
"text": "Planning Data",
"url": "https://www.planning.data.gov.uk/entity/7010000944"
}
},
{
"name": "Bankside and Borough District Town Centre",
"description": "Demolition of commercial buildings and construction of new dwellinghouses is restricted",
"source": "https://www.planning.data.gov.uk/entity/7010001042"
"source": {
"text": "Planning Data",
"url": "https://www.planning.data.gov.uk/entity/7010001042"
}
},
{
"name": "Central Activities Zone",
"description": "Change of use from Class E to residential is restricted",
"source": "https://www.planning.data.gov.uk/entity/7010001055"
"source": {
"text": "Planning Data",
"url": "https://www.planning.data.gov.uk/entity/7010001055"
}
},
{
"name": "Bankside and Borough District Town Centre",
"description": "Change of use from Class E to residential is restricted",
"source": "https://www.planning.data.gov.uk/entity/7010001153"
"source": {
"text": "Planning Data",
"url": "https://www.planning.data.gov.uk/entity/7010001153"
}
}
]
},
Expand Down Expand Up @@ -202,7 +217,7 @@
"intersects": false
},
{
"value": "designated.SPA",
"value": "nature.SPA",
"description": "Special Protection Area (SPA)",
"intersects": false
},
Expand Down Expand Up @@ -1102,7 +1117,22 @@
"source": "PlanX",
"service": {
"flowId": "c6628103-c648-4663-81e1-bfa0a1a18340",
"url": "https://www.editor.planx.dev/southwark/apply-for-prior-approval/preview"
"url": "https://www.editor.planx.dev/southwark/apply-for-prior-approval/preview",
"files": {
"required": [
{
"value": "otherDrawing",
"description": "Other - drawing"
}
],
"recommended": [
{
"value": "sitePlan.proposed",
"description": "Site plan - proposed"
}
],
"optional": []
}
},
"submittedAt": "2023-10-02T00:00:00Z",
"schema": "https://theopensystemslab.github.io/digital-planning-data-schemas/@next/schema.json"
Expand Down
18 changes: 18 additions & 0 deletions schema/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3220,6 +3220,24 @@
],
"type": "object"
},
{
"additionalProperties": false,
"properties": {
"description": {
"const": "Viability Appraisal",
"type": "string"
},
"value": {
"const": "viabilityAppraisal",
"type": "string"
}
},
"required": [
"value",
"description"
],
"type": "object"
},
{
"additionalProperties": false,
"properties": {
Expand Down
Loading