chore: Tidy up typos in enums #213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
commented
Jul 23, 2024
| 'commercial.community.cemetery.columbarium': 'Columbarium', | ||
| 'commercial.community.cemetery.crematorium': 'Crematorium', | ||
| 'commercial.community.cemetery.chapelOfRest': 'Chapel Of Rest', | ||
| 'commercial.community.cemetery.cemetery': 'Cemetery', |
There was a problem hiding this comment.
commercial.community.cemetery.cemetery does match the spreadsheet, but is this actually correct / meaningful?
There was a problem hiding this comment.
Cleaning up our own typos across project types, res units, and constraints seems right to me - but I'm honestly less sure about property types since these are essentially externally sourced / setup to match classification codes returned from OS ?
DafyddLlyr
force-pushed
the
dp/enum-typo-fixes
branch
from
d75f4ec to
7ce609f
Compare
|
Closed - many (most) of these have been resolved whilst updating to the new schema, and outstanding ones either match references in legislation, or are yet to be resolved as part of a content update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few typos I've found in the
/enumsfolder.Some of these (typos in types and descriptions) should be uncontreversion, others I actually just wanted to cross-check - it's possible we're matching different spellings in legislation? I appreciate that some of these will spill across into related content changes as well.
Actual data value changes in this PR -
environmnentalImpact→environmentalImpactcommercial.ancilliary→commercial.ancillarycommercial.industrial.distribution.solidFueld→commercial.industrial.distribution.solidFuelcommercial.utility.telecoms.exhange→commercial.utility.telecoms.exchangex.y.cemetary.z→x.y.cemetery.zI've also requested input from the services team on OSL Slack.