Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Tidy up typos in enums #213

Closed
wants to merge 1 commit into from
Closed

chore: Tidy up typos in enums #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions schemas/digitalPlanningApplication.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5636,7 +5636,7 @@
"additionalProperties": false,
"properties": {
"description": {
"const": "Student accomodation",
"const": "Student accommodation",
"type": "string"
},
"value": {
Expand Down Expand Up @@ -11050,7 +11050,7 @@
"additionalProperties": false,
"properties": {
"description": {
"const": "Install an aerial antennea",
"const": "Install an aerial antennae",
"type": "string"
},
"value": {
Expand Down Expand Up @@ -11086,7 +11086,7 @@
"additionalProperties": false,
"properties": {
"description": {
"const": "Install a barbeque",
"const": "Install a barbecue",
"type": "string"
},
"value": {
Expand Down Expand Up @@ -12652,7 +12652,7 @@
"additionalProperties": false,
"properties": {
"description": {
"const": "Replace door with winoow on the rear of a building",
"const": "Replace door with window on the rear of a building",
"type": "string"
},
"value": {
Expand Down Expand Up @@ -13822,7 +13822,7 @@
"additionalProperties": false,
"properties": {
"description": {
"const": "Total demolition of a isted building",
"const": "Total demolition of a listed building",
"type": "string"
},
"value": {
Expand Down Expand Up @@ -15860,7 +15860,7 @@
"type": "string"
},
"value": {
"const": "commercial.ancilliary",
"const": "commercial.ancillary",
"type": "string"
}
},
Expand Down Expand Up @@ -16040,7 +16040,7 @@
"type": "string"
},
"value": {
"const": "commercial.community.cemetary",
"const": "commercial.community.cemetery",
"type": "string"
}
},
Expand All @@ -16058,7 +16058,7 @@
"type": "string"
},
"value": {
"const": "commercial.community.cemetary.columbarium",
"const": "commercial.community.cemetery.columbarium",
"type": "string"
}
},
Expand All @@ -16076,7 +16076,7 @@
"type": "string"
},
"value": {
"const": "commercial.community.cemetary.crematorium",
"const": "commercial.community.cemetery.crematorium",
"type": "string"
}
},
Expand All @@ -16094,7 +16094,7 @@
"type": "string"
},
"value": {
"const": "commercial.community.cemetary.chapelOfRest",
"const": "commercial.community.cemetery.chapelOfRest",
"type": "string"
}
},
Expand All @@ -16112,7 +16112,7 @@
"type": "string"
},
"value": {
"const": "commercial.community.cemetary.cemetary",
"const": "commercial.community.cemetery.cemetery",
"type": "string"
}
},
Expand All @@ -16130,7 +16130,7 @@
"type": "string"
},
"value": {
"const": "commercial.community.cemetary.military",
"const": "commercial.community.cemetery.military",
"type": "string"
}
},
Expand All @@ -16148,7 +16148,7 @@
"type": "string"
},
"value": {
"const": "commercial.community.cemetary.mortuary",
"const": "commercial.community.cemetery.mortuary",
"type": "string"
}
},
Expand Down Expand Up @@ -16648,7 +16648,7 @@
"additionalProperties": false,
"properties": {
"description": {
"const": "Holiday Let/Accomodation/Short-Term Let Other Than CH01",
"const": "Holiday Let/Accommodation/Short-Term Let Other Than CH01",
"type": "string"
},
"value": {
Expand Down Expand Up @@ -17390,7 +17390,7 @@
"type": "string"
},
"value": {
"const": "commercial.industrial.distribution.solidFueld",
"const": "commercial.industrial.distribution.solidFuel",
"type": "string"
}
},
Expand Down Expand Up @@ -20702,7 +20702,7 @@
"type": "string"
},
"value": {
"const": "commercial.utility.telecoms.exhange",
"const": "commercial.utility.telecoms.exchange",
"type": "string"
}
},
Expand Down Expand Up @@ -22642,7 +22642,7 @@
"additionalProperties": false,
"properties": {
"description": {
"const": "Picnic / Barbeque Site",
"const": "Picnic / Barbecue Site",
"type": "string"
},
"value": {
Expand Down
6 changes: 3 additions & 3 deletions types/schemas/digitalPlanningApplication/enums/PlanningConstraints.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,15 @@ export const PlanningDesignations = {
tpo: 'Tree Preservation Order (TPO) or zone',
};

type PlanningDesigationKeys = keyof typeof PlanningDesignations;
type PlanningDesignationKeys = keyof typeof PlanningDesignations;

type GenericPlanningDesignation<TKey extends PlanningDesigationKeys> = {
type GenericPlanningDesignation<TKey extends PlanningDesignationKeys> = {
value: TKey;
description: (typeof PlanningDesignations)[TKey];
};

type PlanningDesignationMap = {
[K in PlanningDesigationKeys]: GenericPlanningDesignation<K>;
[K in PlanningDesignationKeys]: GenericPlanningDesignation<K>;
};

type BasePlanningDesignation =
Expand Down
8 changes: 4 additions & 4 deletions types/schemas/digitalPlanningApplication/enums/ProjectTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,9 @@ export const ProjectTypes = {
'alter.equipment.airConditioning': 'Install an air conditioning unit',
'alter.equipment.alarm': 'Install a security alarm',
'alter.equipment.antennae': 'Install a satellite dish or aerial',
'alter.equipment.antennae.aerial': 'Install an aerial antennea',
'alter.equipment.antennae.aerial': 'Install an aerial antennae',
'alter.equipment.antennae.dish': 'Install a satellite dish',
'alter.equipment.bbq': 'Install a barbeque',
'alter.equipment.bbq': 'Install a barbecue',
'alter.equipment.biomass': 'Install a flue with a biomass burner',
'alter.equipment.cctv': 'Install CCTV cameras',
'alter.equipment.charging': 'Install a car charging point',
Expand Down Expand Up @@ -165,7 +165,7 @@ export const ProjectTypes = {
'alter.replace.doorsToWindows.front':
'Replace door with window on the front of a building',
'alter.replace.doorsToWindows.rear':
'Replace door with winoow on the rear of a building',
'Replace door with window on the rear of a building',
'alter.replace.doorsToWindows.side':
'Replace door with window on the side of a building',
'alter.replace.windowsToDoors': 'Replace window with door',
Expand Down Expand Up @@ -239,7 +239,7 @@ export const ProjectTypes = {
'demolish.full': 'Total demolition of a building',
'demolish.internal': 'Demolish internal walls',
'demolish.listed': 'Demolish a listed building',
'demolish.listed.full': 'Total demolition of a isted building',
'demolish.listed.full': 'Total demolition of a listed building',
'demolish.listed.part': 'Demolish part of a listed building',
'demolish.outbuilding': 'Demolish an outbuilding (such as a garage or barn)',
'demolish.outbuilding.full':
Expand Down
24 changes: 12 additions & 12 deletions types/schemas/digitalPlanningApplication/enums/PropertyTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export const PropertyTypes = {
'commercial.horticulture.vineyard': 'Vineyard',
'commercial.horticulture.watercress': 'Watercress Bed',
'commercial.abattoir': 'Slaughter House / Abattoir',
'commercial.ancilliary': 'Ancillary Building',
'commercial.ancillary': 'Ancillary Building',
'commercial.community': 'Community Services',
'commercial.community.court': 'Law Court',
'commercial.community.prison': 'Prison',
Expand All @@ -27,14 +27,14 @@ export const PropertyTypes = {
'Public / Village Hall / Other Community Facility',
'commercial.community.hall.club': 'Youth Recreational / Social Club',
'commercial.community.wc': 'Public Convenience',
'commercial.community.cemetary':
'commercial.community.cemetery':
'Cemetery / Crematorium / Graveyard. In Current Use.',
'commercial.community.cemetary.columbarium': 'Columbarium',
'commercial.community.cemetary.crematorium': 'Crematorium',
'commercial.community.cemetary.chapelOfRest': 'Chapel Of Rest',
'commercial.community.cemetary.cemetary': 'Cemetery',
'commercial.community.cemetary.military': 'Military Cemetery',
'commercial.community.cemetary.mortuary': 'Mortuary',
'commercial.community.cemetery.columbarium': 'Columbarium',
'commercial.community.cemetery.crematorium': 'Crematorium',
'commercial.community.cemetery.chapelOfRest': 'Chapel Of Rest',
'commercial.community.cemetery.cemetery': 'Cemetery',
Copy link
Contributor Author

@DafyddLlyr DafyddLlyr Jul 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commercial.community.cemetery.cemetery does match the spreadsheet, but is this actually correct / meaningful?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaning up our own typos across project types, res units, and constraints seems right to me - but I'm honestly less sure about property types since these are essentially externally sourced / setup to match classification codes returned from OS ?

'commercial.community.cemetery.military': 'Military Cemetery',
'commercial.community.cemetery.mortuary': 'Mortuary',
'commercial.community.religious':
'Church Hall / Religious Meeting Place / Hall',
'commercial.community.services': 'Community Service Centre / Office',
Expand Down Expand Up @@ -67,7 +67,7 @@ export const PropertyTypes = {
'Boarding / Guest House / Bed And Breakfast / Youth Hostel',
'commercial.guest.hostel.youth': 'Youth Hostel',
'commercial.guest.shortLet':
'Holiday Let/Accomodation/Short-Term Let Other Than CH01',
'Holiday Let/Accommodation/Short-Term Let Other Than CH01',
'commercial.guest.hotel': 'Hotel/Motel',
'commercial.industrial':
'Industrial Applicable to manufacturing, engineering, maintenance, storage / wholesale distribution and extraction sites',
Expand Down Expand Up @@ -111,7 +111,7 @@ export const PropertyTypes = {
'commercial.industrial.light.storage.solidFuel': 'Solid Fuel Storage',
'commercial.industrial.light.storage.timber': 'Timber Storage',
'commercial.industrial.distribution': 'Wholesale Distribution',
'commercial.industrial.distribution.solidFueld': 'Solid Fuel Distribution',
'commercial.industrial.distribution.solidFuel': 'Solid Fuel Distribution',
'commercial.industrial.distribution.timber': 'Timber Distribution',
'commercial.industrial.recycling': 'Recycling Plant',
'commercial.industrial.incineration': 'Incinerator / Waste Transfer Station',
Expand Down Expand Up @@ -309,7 +309,7 @@ export const PropertyTypes = {
'commercial.utility.water.waste': 'Waste Water Distribution / Pumping',
'commercial.utility.telecoms': 'Telecommunication',
'commercial.utility.telecoms.mast': 'Telecommunications Mast',
'commercial.utility.telecoms.exhange': 'Telephone Exchange',
'commercial.utility.telecoms.exchange': 'Telephone Exchange',
'commercial.utility.waterTreatment':
'Water / Waste Water / Sewage Treatment Works',
'commercial.utility.waterTreatment.waste': 'Waste Water Treatment',
Expand Down Expand Up @@ -425,7 +425,7 @@ export const PropertyTypes = {
'other.transport.road.infrastructure': 'Road Infrastructure Services',
'other.unsupported': 'Unsupported Site',
'other.unsupported.cycleParking': 'Cycle Parking Facility',
'other.unsupported.picnic': 'Picnic / Barbeque Site',
'other.unsupported.picnic': 'Picnic / Barbecue Site',
'other.unsupported.travellingPersons': 'Travelling Persons Site',
'other.unsupported.shelter': 'Shelter (Not Including Bus Shelter)',
'parent.street': 'Street Record',
Expand Down
2 changes: 1 addition & 1 deletion types/schemas/digitalPlanningApplication/enums/ResidentialUnitTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const GLAResidentialUnitTypes = {
LW: 'Live/work unit',
other: 'Other',
semiDetached: 'Semi-detached home',
student: 'Student accomodation',
student: 'Student accommodation',
studio: 'Studio or bedsit',
terraced: 'Terraced home',
};
Expand Down