Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve definitions based on specific application type #247

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Sep 20, 2024

A few steps towards #244

Changes:

  • data.applicant.ownership definitions adjusted & commented back in across all example payloads
  • type error in data.applicant.maintenanceContact fixed
  • data.property and data.proposal are now variants by primary application type (data.proposal still very open, needs full content review)
  • data.property.materials & data.property.use definitions adjusted & commented back in across all example payloads

@jessicamcinchak jessicamcinchak marked this pull request as ready for review September 20, 2024 08:12
@jessicamcinchak jessicamcinchak requested a review from a team September 20, 2024 08:12
@jessicamcinchak jessicamcinchak merged commit d3c4f97 into main Sep 20, 2024
3 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/more-app-type-rules branch September 20, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants