Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve definitions based on specific application type #247

Merged
merged 3 commits into from
Sep 20, 2024
Merged

chore: improve definitions based on specific application type #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3368494
adjust applicant definitions
jessicamcinchak Sep 20, 2024
5c00a77
remove unused import
jessicamcinchak Sep 20, 2024
fb35c0e
add property and proposal variants
jessicamcinchak Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 42 additions & 42 deletions examples/prototypeApplication/data/landDrainageConsent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,48 +28,48 @@ export const landDrainageConsentPrototype: PrototypeApplication = {
siteContact: {
role: 'applicant',
},
// ownership: {
// interest: 'other',
// },
// maintenanceContact: [
// {
// when: 'duringConstruction',
// address: {
// line1: 'Pevensey Castle',
// town: 'Pevensey',
// postcode: 'PE737SY',
// },
// contact: {
// name: {
// title: 'Count',
// first: 'Robert',
// last: 'of Mortain',
// },
// email: '[email protected]',
// phone: '012345678901',
// },
// },
// {
// when: 'afterConstruction',
// address: {
// line1: 'Dover Castle',
// town: 'Dover',
// postcode: 'DO737CA',
// },
// contact: {
// name: {
// title: 'Baron',
// first: 'Roger',
// last: 'De Leybourne',
// },
// email: '[email protected]',
// phone: '098765432109',
// company: {
// name: "The Barons' Revolt",
// },
// },
// },
// ],
ownership: {
interest: 'other',
},
maintenanceContact: [
{
when: 'duringConstruction',
address: {
line1: 'Pevensey Castle',
town: 'Pevensey',
postcode: 'PE737SY',
},
contact: {
name: {
title: 'Count',
first: 'Robert',
last: 'of Mortain',
},
email: '[email protected]',
phone: {primary: '012345678901'},
},
},
{
when: 'afterConstruction',
address: {
line1: 'Dover Castle',
town: 'Dover',
postcode: 'DO737CA',
},
contact: {
name: {
title: 'Baron',
first: 'Roger',
last: 'De Leybourne',
},
email: '[email protected]',
phone: {primary: '098765432109'},
company: {
name: "The Barons' Revolt",
},
},
},
],
},
property: {
address: {
Expand Down
64 changes: 32 additions & 32 deletions examples/prototypeApplication/data/listedBuildingConsent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,38 +30,38 @@ export const listedBuildingConsentPrototype: PrototypeApplication = {
email: '[email protected]',
phone: '987654321',
},
// ownership: {
// interest: 'owner.sole',
// certificate: 'b',
// noticeGiven: true,
// agriculturalTenants: true,
// ownersKnown: 'all',
// owners: [
// {
// name: 'Rowlf the Dog',
// address: {
// line1: '123 Sesame Street',
// town: 'New York City',
// postcode: '10023',
// country: 'USA',
// },
// noticeDate: '2024-04-01',
// },
// {
// name: 'Rizzo the Rat',
// address: {
// line1: '123 Sesame Street',
// town: 'New York City',
// postcode: '10023',
// country: 'USA',
// },
// noticeDate: '2024-04-01',
// },
// ],
// declaration: {
// accurate: true,
// },
// },
ownership: {
interest: 'owner.sole',
certificate: 'b',
noticeGiven: true,
agriculturalTenants: true,
ownersKnown: 'all',
owners: [
{
name: 'Rowlf the Dog',
address: {
line1: '123 Sesame Street',
town: 'New York City',
postcode: '10023',
country: 'USA',
},
noticeDate: '2024-04-01',
},
{
name: 'Rizzo the Rat',
address: {
line1: '123 Sesame Street',
town: 'New York City',
postcode: '10023',
country: 'USA',
},
noticeDate: '2024-04-01',
},
],
declaration: {
accurate: true,
},
},
},
property: {
address: {
Expand Down
37 changes: 19 additions & 18 deletions examples/prototypeApplication/data/planningPermission/major.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import {PrototypeApplication} from '../../../../types/schemas/prototypeApplication';
import {PPApplicant} from '../../../../types/schemas/prototypeApplication/data/Applicant';

const version = process.env['VERSION'] || '@next';

Expand Down Expand Up @@ -35,24 +36,24 @@ export const planningPermissionMajorPrototype: PrototypeApplication = {
certificate: 'b',
noticeGiven: true,
ownersKnown: 'all',
// owners: [
// {
// name: 'Agamemnon Agricullen',
// address: {
// town: 'Mycenae',
// line1: 'Aggy Avenue',
// line2: '',
// county: '',
// country: 'Greece',
// postcode: '212 00',
// },
// noticeGiven: true,
// },
// ],
owners: [
{
name: 'Agamemnon Agricullen',
address: {
town: 'Mycenae',
line1: 'Aggy Avenue',
line2: '',
county: '',
country: 'Greece',
postcode: '212 00',
},
noticeDate: '2024-01-01',
},
],
declaration: {
accurate: true,
},
},
} as PPApplicant['ownership'],
agent: {
name: {
first: 'Andy',
Expand Down Expand Up @@ -87,9 +88,9 @@ export const planningPermissionMajorPrototype: PrototypeApplication = {
localAuthorityDistrict: ['Buckinghamshire', 'South Bucks'],
region: 'South East',
type: 'other.unsupported',
// use: {
// description: 'Vacant brownfield',
// },
use: {
description: 'Vacant brownfield',
},
planning: {
sources: [
'https://api.editor.planx.dev/gis/buckinghamshire?geom=POLYGON+%28%28-0.5202563671906586+51.51349326091676%2C+-0.5162271673824664+51.51342965453125%2C+-0.5160930726385158+51.5119189712527%2C+-0.5186025432309797+51.51150473816995%2C+-0.5192921685359919+51.51150076298916%2C+-0.5197391470751718+51.5115882253788%2C+-0.5204032314768795+51.51156039632619%2C+-0.5207544293552119+51.512609937924225%2C+-0.5202563671906586+51.51349326091676%29%29&sessionId=180da003-279d-40dc-b538-a616c8c2a700',
Expand Down
6 changes: 3 additions & 3 deletions examples/prototypeApplication/data/planningPermission/minor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,9 @@ export const planningPermissionMinorPrototype: PrototypeApplication = {
},
],
},
// materials: {
// boundary: 'black painted timber',
// },
materials: {
boundary: 'black painted timber',
},
},
application: {
fee: {
Expand Down
48 changes: 47 additions & 1 deletion examples/prototypeApplication/landDrainageConsent.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,53 @@
},
"siteContact": {
"role": "applicant"
}
},
"ownership": {
"interest": "other"
},
"maintenanceContact": [
{
"when": "duringConstruction",
"address": {
"line1": "Pevensey Castle",
"town": "Pevensey",
"postcode": "PE737SY"
},
"contact": {
"name": {
"title": "Count",
"first": "Robert",
"last": "of Mortain"
},
"email": "[email protected]",
"phone": {
"primary": "012345678901"
}
}
},
{
"when": "afterConstruction",
"address": {
"line1": "Dover Castle",
"town": "Dover",
"postcode": "DO737CA"
},
"contact": {
"name": {
"title": "Baron",
"first": "Roger",
"last": "De Leybourne"
},
"email": "[email protected]",
"phone": {
"primary": "098765432109"
},
"company": {
"name": "The Barons' Revolt"
}
}
}
]
},
"property": {
"address": {
Expand Down
32 changes: 32 additions & 0 deletions examples/prototypeApplication/listedBuildingConsent.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,38 @@
"name": "Gonzo The Great",
"email": "[email protected]",
"phone": "987654321"
},
"ownership": {
"interest": "owner.sole",
"certificate": "b",
"noticeGiven": true,
"agriculturalTenants": true,
"ownersKnown": "all",
"owners": [
{
"name": "Rowlf the Dog",
"address": {
"line1": "123 Sesame Street",
"town": "New York City",
"postcode": "10023",
"country": "USA"
},
"noticeDate": "2024-04-01"
},
{
"name": "Rizzo the Rat",
"address": {
"line1": "123 Sesame Street",
"town": "New York City",
"postcode": "10023",
"country": "USA"
},
"noticeDate": "2024-04-01"
}
],
"declaration": {
"accurate": true
}
}
},
"property": {
Expand Down
17 changes: 17 additions & 0 deletions examples/prototypeApplication/planningPermission/major.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,20 @@
"certificate": "b",
"noticeGiven": true,
"ownersKnown": "all",
"owners": [
{
"name": "Agamemnon Agricullen",
"address": {
"town": "Mycenae",
"line1": "Aggy Avenue",
"line2": "",
"county": "",
"country": "Greece",
"postcode": "212 00"
},
"noticeDate": "2024-01-01"
}
],
"declaration": {
"accurate": true
}
Expand Down Expand Up @@ -72,6 +86,9 @@
],
"region": "South East",
"type": "other.unsupported",
"use": {
"description": "Vacant brownfield"
},
"planning": {
"sources": [
"https://api.editor.planx.dev/gis/buckinghamshire?geom=POLYGON+%28%28-0.5202563671906586+51.51349326091676%2C+-0.5162271673824664+51.51342965453125%2C+-0.5160930726385158+51.5119189712527%2C+-0.5186025432309797+51.51150473816995%2C+-0.5192921685359919+51.51150076298916%2C+-0.5197391470751718+51.5115882253788%2C+-0.5204032314768795+51.51156039632619%2C+-0.5207544293552119+51.512609937924225%2C+-0.5202563671906586+51.51349326091676%29%29&sessionId=180da003-279d-40dc-b538-a616c8c2a700"
Expand Down
3 changes: 3 additions & 0 deletions examples/prototypeApplication/planningPermission/minor.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,9 @@
]
}
]
},
"materials": {
"boundary": "black painted timber"
}
},
"application": {
Expand Down
Loading