fix: use Digital Planning Application v0.1.1 and fix validation errors #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessicamcinchak
commented
Oct 20, 2023
| value: [flag.category, flag.text].join(" / "), | ||
| description: flag.description, | ||
| value: title, | ||
| description: this.findDescriptionFromValue("ResultFlag", title), // flag.description may be custom text |
There was a problem hiding this comment.
This still won't validate successfully if an application is also using custom flag titles - but it should catch more cases and I'll keep adjusting as we work on flags logic & multiple results overall. I'm hesitant to remove the enum type for "ResultFlag" entirely yet.
DafyddLlyr
approved these changes
Oct 20, 2023
|
PR description and format massively helpful thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
metadata.service.publishedFlowIdsessionIdd7cf2da2-fb4c-4930-841d-33e4ed23d905fe6fa607-ee22-4e05-b4e0-382d5d00b9e62e3cabab-633d-4869-a5de-0752c612ac14faa32d08-246d-4510-97ef-689abb2b36dc97c4fe80-2862-4e7e-9e0c-3786ed31a5d6proposal.drawing.locationPlaninstead of drawing; our schema incorrectly marks boundary as required890ccf44-4c0f-473d-ad7b-f63cae24b19eplanx_valuerather thanproperty.type, raising enum type error when OS returns undefinedf4cc3953-bfb1-47d1-a9ce-955a6bd6b549planx_valuerather thanproperty.type, raising enum type error when OS returns undefinedf4c23bee-f0a4-4915-8e85-3307429a8292applicant.interest= "other" which we haven't accounted for in our enum type878215a1-ddad-49e8-8040-f52d00c228b3proposal.photograph.evidencewas provided which we haven't accounted for in our enum typeRelies on some fixes here: theopensystemslab/digital-planning-data-schemas#58 (not included in v0.1.1 release)