feat: include the ODP Schema as "application.json" in files sent to Uniform #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to theopensystemslab/planx-new#2804
Rather than making this an optional argument on the
buildSubmissionExportZip()method likeincludeDigitalPlanningSchemaJSON- we can just include by default for supported application types (Uniform = always LDC) which will give councils more flexibility (eg retrieve the JSON from DMS rather than email inbox; not have to configure a service to send to all three possible destinations) and communicates to Idox that we're ready/able to be sending this new data format regardless of Nexus.Once this is approved and merged to
mainalong with 2804, I'll submit a test LDC on staging and get a council PO to confirm it can be received correctly via DMS and doesn't break before going to production.