Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include the ODP schema as "application.json" in submission zips for supported application types #2804

Merged
merged 4 commits into from
Feb 22, 2024

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Feb 19, 2024

Adds the ODP Schema JSON to the zip file for supported application types so that councils can build reports.

Testing notes
I've set up all flows under Lambeth on this pizza to email to [email protected]

  1. You can submit an LDC successfully and the zip includes application.json: https://2804.planx.pizza/lambeth/apply-for-a-lawful-development-certificate/preview
    • Double check the Hasura events to confirm that each send to email, BOPS, and Uniform submissions succeed
  2. You can submit a discretionary service successfully (send to email only) and the zip does NOT include application.json: https://2804.planx.pizza/lambeth/send-to-email-test/preview

Related theopensystemslab/planx-core#309

Copy link

github-actions bot commented Feb 19, 2024

Removed vultr server and associated DNS entries

Copy link
Contributor

@Mike-Heneghan Mike-Heneghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected for me on the Pizza when testing and the code looks great 👍

@jessicamcinchak jessicamcinchak merged commit 4484938 into main Feb 22, 2024
12 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/add-odp-schema-zip branch February 22, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants