-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update formatRawProjectTypes
to reference schema instead of static database table
#445
Merged
jessicamcinchak
merged 6 commits into
main
from
jess/update-formatRawProjectTypes-schema
Jul 12, 2024
Merged
chore: update formatRawProjectTypes
to reference schema instead of static database table
#445
jessicamcinchak
merged 6 commits into
main
from
jess/update-formatRawProjectTypes-schema
Jul 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
reviewed
Jul 11, 2024
jessicamcinchak
commented
Jul 12, 2024
jessicamcinchak
commented
Jul 12, 2024
DafyddLlyr
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small question!
…ess/update-formatRawProjectTypes-schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
project_types
database table is very static and this has been causing complaints of 'not found' project types in Notify email templates. Checking against the ODP Schema "ProjectType" definition should ensure a much more up-to-date list and fewer unknownsChanges:
formatRawProjectTypes
function to reference the schema instead of making a GraphQL query$client
Intl.ListFormat
via https://formatjs.io/docs/polyfills/intl-listformat/ as we see this popup occassionally via Airbrake !Future planx-new PRs:
formatRawProjectTypes
planx-new#3410project_types
database table