bump mui/material and add mui/base as direct dependency #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freemvmt
changed the title
freemvmt
requested review from
jessicamcinchak and
DafyddLlyr
and removed request for
jessicamcinchak
3 tasks
jessicamcinchak
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Aha great find with this one 💡 same bug has been plaguing our nightly regression tests in planx-new ! eg https://github.com/theopensystemslab/planx-new/actions/runs/10138961762/job/28031472035
Will go ahead and merge this one today & bump accordingly in planx-new 👍 (then should be a simple rebase of your API PR later this week when you're back!)
This was referenced Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mui/material does not list @mui/base as a dependency, and yet it does rely on it! I think this is probably because base appears to be in alpha, and seems to be directly replacing what was called
@mui/core.This was leading to errors like the below when trying to run tests for changes to
planx-new/api.planx.ukin #3464.But explicitly adding
@mui/baseas a dependency in this project (got that idea here) seems to solve this issue on local. I also bumped@mui/materialto latest minor version while I was at it :)Resources