fix: Detect presence of httpOnly cookie
#3324
DafyddLlyrpull-request.yml
on: pull_request
Check file changes
3s
Run Integration tests
5m 16s
Run API Tests
1m 50s
Run React Tests
4m 16s
Generate Hasura Change Summary
0s
E2E tests
9m 34s
Run Pulumi Preview
0s
Run Healthcheck on Pizza Services
33s
Annotations
7 errors, 17 warnings, and 1 notice
|
[chromium] › login.spec.ts:29:7 › Login › setting a cookie bypasses login:
e2e/tests/ui-driven/src/globalHelpers.ts#L58
1) [chromium] › login.spec.ts:29:7 › Login › setting a cookie bypasses login ─────────────────────
Error: browserContext.addCookies: cookies[1].value: expected string, got boolean
at globalHelpers.ts:58
56 | const page = await browserContext.newPage();
57 | const token = generateAuthenticationToken(`${userId}`);
> 58 | await browserContext.addCookies([
| ^
59 | {
60 | name: "jwt",
61 | domain: "localhost",
at createAuthenticatedSession (/home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/globalHelpers.ts:58:24)
at /home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/login.spec.ts:30:18
|
|
[chromium] › login.spec.ts:29:7 › Login › setting a cookie bypasses login:
e2e/tests/ui-driven/src/globalHelpers.ts#L58
1) [chromium] › login.spec.ts:29:7 › Login › setting a cookie bypasses login ─────────────────────
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: browserContext.addCookies: cookies[1].value: expected string, got boolean
at globalHelpers.ts:58
56 | const page = await browserContext.newPage();
57 | const token = generateAuthenticationToken(`${userId}`);
> 58 | await browserContext.addCookies([
| ^
59 | {
60 | name: "jwt",
61 | domain: "localhost",
at createAuthenticatedSession (/home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/globalHelpers.ts:58:24)
at /home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/login.spec.ts:30:18
|
|
[chromium] › login.spec.ts:29:7 › Login › setting a cookie bypasses login:
e2e/tests/ui-driven/src/globalHelpers.ts#L58
1) [chromium] › login.spec.ts:29:7 › Login › setting a cookie bypasses login ─────────────────────
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Error: browserContext.addCookies: cookies[1].value: expected string, got boolean
at globalHelpers.ts:58
56 | const page = await browserContext.newPage();
57 | const token = generateAuthenticationToken(`${userId}`);
> 58 | await browserContext.addCookies([
| ^
59 | {
60 | name: "jwt",
61 | domain: "localhost",
at createAuthenticatedSession (/home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/globalHelpers.ts:58:24)
at /home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/login.spec.ts:30:18
|
|
[chromium] › login.spec.ts:44:7 › Login › shows error toast when there is a network error and removes it when a retry is successful:
e2e/tests/ui-driven/src/globalHelpers.ts#L58
2) [chromium] › login.spec.ts:44:7 › Login › shows error toast when there is a network error and removes it when a retry is successful
Error: browserContext.addCookies: cookies[1].value: expected string, got boolean
at globalHelpers.ts:58
56 | const page = await browserContext.newPage();
57 | const token = generateAuthenticationToken(`${userId}`);
> 58 | await browserContext.addCookies([
| ^
59 | {
60 | name: "jwt",
61 | domain: "localhost",
at createAuthenticatedSession (/home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/globalHelpers.ts:58:24)
at /home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/login.spec.ts:47:18
|
|
[chromium] › login.spec.ts:44:7 › Login › shows error toast when there is a network error and removes it when a retry is successful:
e2e/tests/ui-driven/src/globalHelpers.ts#L58
2) [chromium] › login.spec.ts:44:7 › Login › shows error toast when there is a network error and removes it when a retry is successful
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: browserContext.addCookies: cookies[1].value: expected string, got boolean
at globalHelpers.ts:58
56 | const page = await browserContext.newPage();
57 | const token = generateAuthenticationToken(`${userId}`);
> 58 | await browserContext.addCookies([
| ^
59 | {
60 | name: "jwt",
61 | domain: "localhost",
at createAuthenticatedSession (/home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/globalHelpers.ts:58:24)
at /home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/login.spec.ts:47:18
|
|
[chromium] › login.spec.ts:44:7 › Login › shows error toast when there is a network error and removes it when a retry is successful:
e2e/tests/ui-driven/src/globalHelpers.ts#L58
2) [chromium] › login.spec.ts:44:7 › Login › shows error toast when there is a network error and removes it when a retry is successful
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Error: browserContext.addCookies: cookies[1].value: expected string, got boolean
at globalHelpers.ts:58
56 | const page = await browserContext.newPage();
57 | const token = generateAuthenticationToken(`${userId}`);
> 58 | await browserContext.addCookies([
| ^
59 | {
60 | name: "jwt",
61 | domain: "localhost",
at createAuthenticatedSession (/home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/globalHelpers.ts:58:24)
at /home/runner/work/planx-new/planx-new/e2e/tests/ui-driven/src/login.spec.ts:47:18
|
|
E2E tests
Process completed with exit code 1.
|
|
Run API Tests:
api.planx.uk/lib/notify/index.ts#L73
Unexpected any. Specify a different type
|
|
|
|
Run API Tests:
api.planx.uk/modules/auth/strategy/google.ts#L20
Unexpected any. Specify a different type
|
|
Run API Tests:
api.planx.uk/modules/gis/service/classifiedRoads.test.ts#L20
Disabled test suite
|
|
Run API Tests:
api.planx.uk/modules/gis/service/classifiedRoads.ts#L129
Unexpected any. Specify a different type
|
|
Run API Tests:
api.planx.uk/modules/gis/service/classifiedRoads.ts#L150
Unexpected any. Specify a different type
|
|
Run API Tests:
api.planx.uk/modules/gis/service/digitalLand.ts#L72
Unexpected any. Specify a different type
|
|
Run API Tests:
api.planx.uk/modules/gis/service/digitalLand.ts#L73
Unexpected any. Specify a different type
|
|
Run API Tests:
api.planx.uk/modules/gis/service/digitalLand.ts#L107
Unexpected any. Specify a different type
|
|
Run API Tests:
api.planx.uk/modules/gis/service/digitalLand.ts#L156
Unexpected any. Specify a different type
|
|
Upsert Vultr Instance
The following actions uses node12 which is deprecated and will be forced to run on node16: theopensystemslab/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
E2E tests:
e2e/tests/ui-driven/src/invite-to-pay/agent.spec.ts#L92
Unexpected use of networkidle
|
|
E2E tests:
e2e/tests/ui-driven/src/invite-to-pay/nominee.spec.ts#L86
Unexpected use of networkidle
|
|
E2E tests:
e2e/tests/ui-driven/src/invite-to-pay/nominee.spec.ts#L95
Unexpected use of networkidle
|
|
E2E tests:
e2e/tests/ui-driven/src/invite-to-pay/nominee.spec.ts#L130
Unexpected use of networkidle
|
|
Slow Test:
e2e/tests/ui-driven/[chromium] › sections.spec.ts#L1
e2e/tests/ui-driven/[chromium] › sections.spec.ts took 16.8s
|
|
Slow Test:
e2e/tests/ui-driven/[chromium] › save-and-return.spec.ts#L1
e2e/tests/ui-driven/[chromium] › save-and-return.spec.ts took 15.5s
|
|
🎭 Playwright Run Summary
2 failed
[chromium] › login.spec.ts:29:7 › Login › setting a cookie bypasses login ──────────────────────
[chromium] › login.spec.ts:44:7 › Login › shows error toast when there is a network error and removes it when a retry is successful
1 skipped
11 passed (42.7s)
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
playwright-report
Expired
|
15.9 KB |
|