refact(ci): extract reusable workflow

.github/workflows/build-react.yml

@@ -0,0 +1,75 @@
+on:
+  workflow_call:
+    inputs:
+      target:
+        required: true
+        type: string
+      environment:
+        required: true
+        type: string
+
+jobs:
+  build_react:
+    name: Build
+    runs-on: ubuntu-22.04
+    steps:
+      - uses: actions/checkout@v2
+      - uses: cardinalby/export-env-action@v2
+        with:
+          envFile: '.github/workflows/constants.env'
+          expand: true
+          expandWithJobEnv: true
+      - name: Cache build assets
+        id: cache-react-build-assets
+        uses: actions/cache@v3
+        with:
+          path: ./${{ env.EDITOR_DIRECTORY }}/build
+          key: ${{ runner.os }}-${{ hashFiles('editor.planx.uk/**') }}-${{ inputs.environment }}
+      - uses: pnpm/[email protected]
+        if: steps.cache-react-build-assets.outputs.cache-hit != 'true'
+        with:
+          version: ${{ env.PNPM_VERSION }}
+      - uses: actions/setup-node@v2
+        if: steps.cache-react-build-assets.outputs.cache-hit != 'true'
+        with:
+          node-version: ${{ env.NODE_VERSION }}
+          cache: "pnpm"
+          cache-dependency-path: "**/pnpm-lock.yaml"
+      - run: pnpm distribute ../${{ env.EDITOR_DIRECTORY }}
+        if: steps.cache-react-build-assets.outputs.cache-hit != 'true'
+        working-directory: core
+      - run: pnpm install --frozen-lockfile
+        if: steps.cache-react-build-assets.outputs.cache-hit != 'true'
+        working-directory: ${{ env.EDITOR_DIRECTORY }}
+      - run: pnpm build
+        if: steps.cache-react-build-assets.outputs.cache-hit != 'true'
+        env:
+          REACT_APP_AIRBRAKE_PROJECT_ID: ${{ secrets.AIRBRAKE_PROJECT_ID }}
+          REACT_APP_AIRBRAKE_PROJECT_KEY: ${{ secrets.AIRBRAKE_PROJECT_KEY }}
+          REACT_APP_API_URL: https://api.${{ inputs.target }}
+          REACT_APP_ENV: ${{ inputs.environment }}
+          REACT_APP_FEEDBACK_FISH_ID: 65f02de00b90d1
+          REACT_APP_HASURA_URL: https://hasura.${{ inputs.target }}/v1/graphql
+          REACT_APP_SHAREDB_URL: wss://sharedb.${{ inputs.target }}
+          # needed because there's no API to change google's allowed OAuth URLs
+          REACT_APP_GOOGLE_OAUTH_OVERRIDE: "${{ inputs.environment == 'pizza' && 'https://api.editor.planx.dev' || '' }}"
+        working-directory: ${{ env.EDITOR_DIRECTORY }}
+      - name: Upload Build Artifact
+        uses: actions/upload-artifact@v2
+        with:
+          name: build
+          path: ./editor.planx.uk/build
+          if-no-files-found: error
+      - run: pnpm build-storybook
+        if: steps.cache-react-build-assets.outputs.cache-hit != 'true'
+        working-directory: ${{ env.EDITOR_DIRECTORY }}
+        env:
+          # same env as above, if it's job.env it can't access existing env.[variable]
+          REACT_APP_AIRBRAKE_PROJECT_ID: ${{ secrets.AIRBRAKE_PROJECT_ID }}
+          REACT_APP_AIRBRAKE_PROJECT_KEY: ${{ secrets.AIRBRAKE_PROJECT_KEY }}
+          REACT_APP_API_URL: https://api.${{ github.event.number }}.${{ env.DOMAIN }}
+          REACT_APP_FEEDBACK_FISH_ID: 65f02de00b90d1
+          REACT_APP_HASURA_URL: https://hasura.${{ github.event.number }}.${{ env.DOMAIN }}/v1/graphql
+          REACT_APP_SHAREDB_URL: wss://sharedb.${{ github.event.number }}.${{ env.DOMAIN }}
+          REACT_APP_GOOGLE_OAUTH_OVERRIDE: https://api.editor.planx.dev
+          REACT_APP_ENV: ${{ inputs.environment }}

.github/workflows/constants.env

@@ -0,0 +1,4 @@
+DOMAIN=planx.pizza
+EDITOR_DIRECTORY=editor.planx.uk
+PNPM_VERSION=7.8.0
+NODE_VERSION=16.13.1  # 16.13.1 = LTS

.github/workflows/pull-request.yml

@@ -9,11 +9,9 @@ on:
 
 env:
   DOMAIN: planx.pizza
-  FULL_DOMAIN: ${{ github.event.number }}.planx.pizza
-  PULLREQUEST_ID: ${{ github.event.number }}
   EDITOR_DIRECTORY: editor.planx.uk
   PNPM_VERSION: 7.8.0
-  NODE_VERSION: 16.13.1 # 16.13.1 = LTS
+  NODE_VERSION: 16.13.1  # 16.13.1 = LTS
 
 jobs:
   changes:
@@ -172,60 +170,13 @@ jobs:
         working-directory: ${{ env.EDITOR_DIRECTORY }}
 
   build_react_app:
-    name: Build React App
-    runs-on: ubuntu-22.04
+    name: React App
     needs: [changes]
     if: "${{ !contains(needs.changes.outputs.commit, '[skip pizza]') }}"
-    steps:
-      - uses: actions/checkout@v2
-      - name: Cache build assets
-        id: cache-react-build-assets
-        uses: actions/cache@v3
-        with:
-          path: ./${{ env.EDITOR_DIRECTORY }}/build
-          key: ${{ runner.os }}-${{ hashFiles('editor.planx.uk/**') }}
-      - uses: pnpm/[email protected]
-        if: steps.cache-react-build-assets.outputs.cache-hit != 'true'
-        with:
-          version: ${{ env.PNPM_VERSION }}
-      - uses: actions/setup-node@v2
-        if: steps.cache-react-build-assets.outputs.cache-hit != 'true'
-        with:
-          node-version: ${{ env.NODE_VERSION }}
-          cache: "pnpm"
-          cache-dependency-path: "**/pnpm-lock.yaml"
-      - run: pnpm distribute ../${{ env.EDITOR_DIRECTORY }}
-        if: steps.cache-react-build-assets.outputs.cache-hit != 'true'
-        working-directory: core
-      - run: pnpm install --frozen-lockfile
-        if: steps.cache-react-build-assets.outputs.cache-hit != 'true'
-        working-directory: ${{ env.EDITOR_DIRECTORY }}
-      - run: pnpm build
-        if: steps.cache-react-build-assets.outputs.cache-hit != 'true'
-        env:
-          REACT_APP_AIRBRAKE_PROJECT_ID: ${{ secrets.AIRBRAKE_PROJECT_ID }}
-          REACT_APP_AIRBRAKE_PROJECT_KEY: ${{ secrets.AIRBRAKE_PROJECT_KEY }}
-          REACT_APP_API_URL: https://api.${{ env.FULL_DOMAIN }}
-          REACT_APP_FEEDBACK_FISH_ID: 65f02de00b90d1
-          REACT_APP_HASURA_URL: https://hasura.${{ env.FULL_DOMAIN }}/v1/graphql
-          REACT_APP_SHAREDB_URL: wss://sharedb.${{ env.FULL_DOMAIN }}
-          # needed because there's no API to change google's allowed OAuth URLs
-          REACT_APP_GOOGLE_OAUTH_OVERRIDE: https://api.editor.planx.dev
-          REACT_APP_ENV: pizza
-        working-directory: ${{ env.EDITOR_DIRECTORY }}
-      - run: pnpm build-storybook
-        if: steps.cache-react-build-assets.outputs.cache-hit != 'true'
-        working-directory: ${{ env.EDITOR_DIRECTORY }}
-        env:
-          # same env as above, if it's job.env it can't access existing env.[variable]
-          REACT_APP_AIRBRAKE_PROJECT_ID: ${{ secrets.AIRBRAKE_PROJECT_ID }}
-          REACT_APP_AIRBRAKE_PROJECT_KEY: ${{ secrets.AIRBRAKE_PROJECT_KEY }}
-          REACT_APP_API_URL: https://api.${{ env.FULL_DOMAIN }}
-          REACT_APP_FEEDBACK_FISH_ID: 65f02de00b90d1
-          REACT_APP_HASURA_URL: https://hasura.${{ env.FULL_DOMAIN }}/v1/graphql
-          REACT_APP_SHAREDB_URL: wss://sharedb.${{ env.FULL_DOMAIN }}
-          REACT_APP_GOOGLE_OAUTH_OVERRIDE: https://api.editor.planx.dev
-          REACT_APP_ENV: pizza
+    uses: ./.github/workflows/build-react.yml
+    with:
+      target: "${{ github.event.number }}.planx.pizza"
+      environment: "pizza"
 
   pulumi_preview:
     name: Run Pulumi Preview
@@ -251,11 +202,11 @@ jobs:
       - run: pnpm install --frozen-lockfile
         working-directory: infrastructure/application
       - name: Download React build assets
-        id: cache-react-build-assets
         uses: actions/cache@v3
         with:
+          fail-on-cache-miss: true
           path: ./${{ env.EDITOR_DIRECTORY }}/build
-          key: ${{ runner.os }}-${{ hashFiles('editor.planx.uk/**', '!editor.planx/build/**') }}
+          key: ${{ runner.os }}-${{ hashFiles('editor.planx.uk/**', '!editor.planx/build/**') }}-pizza
       - uses: pulumi/actions@v3
         with:
           command: preview
@@ -276,7 +227,7 @@ jobs:
         id: hasura-change
         with:
           github_token: ${{ secrets.GITHUB_TOKEN }}
-          hasura_endpoint: https://hasura.${{ env.FULL_DOMAIN }}
+          hasura_endpoint: https://hasura.${{ github.event.number }}.${{ env.DOMAIN }}
           project_dir: ./hasura.planx.uk
       - uses: marocchino/sticky-pull-request-comment@v2
         if: ${{steps.hasura-change.outputs.change_html != ''}}
@@ -306,7 +257,7 @@ jobs:
           domain: ${{ env.DOMAIN }}
           os_id: 1743
           plan: vc2-1c-1gb
-          pullrequest_id: ${{ env.PULLREQUEST_ID }}
+          pullrequest_id: ${{ github.event.number }}
           region: lhr
           tag: pullrequest
 
@@ -316,14 +267,14 @@ jobs:
         name: Create commands
         uses: appleboy/ssh-action@master
         with:
-          host: ${{ env.FULL_DOMAIN }}
+          host: ${{ github.event.number }}.${{ env.DOMAIN }}
           username: root
           password: ${{ steps.create.outputs.default_password }}
           command_timeout: 20m
           script: |
             git clone "${{ secrets.AUTHENTICATED_REPO_URL }}"
             cd planx-new
-            git fetch origin "pull/${{ env.PULLREQUEST_ID }}/head" && git checkout FETCH_HEAD
+            git fetch origin "pull/${{ github.event.number }}/head" && git checkout FETCH_HEAD
 
             apt-get install awscli -y
             export AWS_ACCESS_KEY_ID=${{ secrets.PIZZA_AWS_ACCESS_KEY_ID }}
@@ -332,7 +283,7 @@ jobs:
 
             ./scripts/pull-secrets.sh
 
-            echo -e "\nROOT_DOMAIN=${{ env.FULL_DOMAIN }}\n" > .env.temp
+            echo -e "\nROOT_DOMAIN=${{ github.event.number }}.${{ env.DOMAIN }}\n" > .env.temp
             cat .env .env.temp .env.staging > .env.pizza
 
             SSH_PASSWORD=${{ secrets.SSH_PASSWORD }} ./scripts/pullrequest/create.sh
@@ -343,15 +294,15 @@ jobs:
         name: Update commands
         uses: appleboy/ssh-action@master
         with:
-          host: ${{ env.FULL_DOMAIN }}
+          host: ${{ github.event.number }}.${{ env.DOMAIN }}
           username: root
           password: ${{ secrets.SSH_PASSWORD }}
           command_timeout: 10m
           script: |
             git clone "${{ secrets.AUTHENTICATED_REPO_URL }}"
             cd planx-new
             git add . && git stash
-            git fetch origin "pull/${{ env.PULLREQUEST_ID }}/head" && git checkout FETCH_HEAD
+            git fetch origin "pull/${{ github.event.number }}/head" && git checkout FETCH_HEAD
 
             apt-get install awscli -y
             export AWS_ACCESS_KEY_ID=${{ secrets.PIZZA_AWS_ACCESS_KEY_ID }}
@@ -360,7 +311,7 @@ jobs:
 
             ./scripts/pull-secrets.sh
 
-            echo -e "\nROOT_DOMAIN=${{ env.FULL_DOMAIN }}\n" > .env.temp
+            echo -e "\nROOT_DOMAIN=${{ github.event.number }}.${{ env.DOMAIN }}\n" > .env.temp
             cat .env .env.temp .env.staging > .env.pizza
 
             ./scripts/pullrequest/update.sh
@@ -369,15 +320,15 @@ jobs:
 
       - uses: actions/checkout@v2
       - name: Download React build assets
-        id: cache-react-build-assets
         uses: actions/cache@v3
         with:
+          fail-on-cache-miss: true
           path: ./${{ env.EDITOR_DIRECTORY }}/build
-          key: ${{ runner.os }}-${{ hashFiles('editor.planx.uk/**', '!editor.planx/build/**') }}
+          key: ${{ runner.os }}-${{ hashFiles('editor.planx.uk/**', '!editor.planx/build/**') }}-pizza
       - name: upload built editor
         uses: appleboy/scp-action@master
         with:
-          host: ${{ env.FULL_DOMAIN }}
+          host: ${{ github.event.number }}.${{ env.DOMAIN }}
           username: root
           password: ${{ secrets.SSH_PASSWORD }}
           source: "./${{ env.EDITOR_DIRECTORY }}/build"
@@ -390,14 +341,14 @@ jobs:
           message: |
             ## Pizza
 
-            Deployed ${{ github.sha }} to https://${{ env.FULL_DOMAIN }}.
+            Deployed ${{ github.sha }} to https://${{ github.event.number }}.${{ env.DOMAIN }}.
 
             Useful links:
-              - [Editor](https://${{ env.FULL_DOMAIN }})
-              - [Storybook](https://storybook.${{ env.FULL_DOMAIN }})
-              - [Hasura](https://hasura.${{ env.FULL_DOMAIN }})
-              - [API](https://api.${{ env.FULL_DOMAIN }})
-              - [ShareDB](https://sharedb.${{ env.FULL_DOMAIN }})
+              - [Editor](https://${{ github.event.number }}.${{ env.DOMAIN }})
+              - [Storybook](https://storybook.${{ github.event.number }}.${{ env.DOMAIN }})
+              - [Hasura](https://hasura.${{ github.event.number }}.${{ env.DOMAIN }})
+              - [API](https://api.${{ github.event.number }}.${{ env.DOMAIN }})
+              - [ShareDB](https://sharedb.${{ github.event.number }}.${{ env.DOMAIN }})
 
   healthcheck:
     name: Run Healthcheck on Pizza Services
@@ -406,15 +357,15 @@ jobs:
     steps:
       - name: API healthcheck
         run: |
-          timeout 150s bash -c "until curl --fail https://api.${{ env.FULL_DOMAIN }}; do sleep 1; done"
+          timeout 150s bash -c "until curl --fail https://api.${{ github.event.number }}.${{ env.DOMAIN }}; do sleep 1; done"
 
       - name: Hasura healthcheck
         run: |
-          timeout 150s bash -c "until curl --fail https://hasura.${{ env.FULL_DOMAIN }}/healthz; do sleep 1; done"
+          timeout 150s bash -c "until curl --fail https://hasura.${{ github.event.number }}.${{ env.DOMAIN }}/healthz; do sleep 1; done"
 
       - name: Editor healthcheck
         run: |
-          timeout 150s bash -c "until curl --fail https://${{ env.FULL_DOMAIN }}; do sleep 1; done"
+          timeout 150s bash -c "until curl --fail https://${{ github.event.number }}.${{ env.DOMAIN }}; do sleep 1; done"
 
 
   lighthouse:
@@ -427,13 +378,13 @@ jobs:
         uses: treosh/lighthouse-ci-action@v9
         id: LHCIAction
         with:
-          urls: | 
+          urls: |
             https://editor.planx.dev/buckinghamshire/find-out-if-you-need-planning-permission/preview
-            https://${{ env.FULL_DOMAIN }}/buckinghamshire/find-out-if-you-need-planning-permission/preview
+            https://${{ github.event.number }}.${{ env.DOMAIN }}/buckinghamshire/find-out-if-you-need-planning-permission/preview
             https://editor.planx.dev/testing/lighthouse-canary-flow/unpublished
-            https://${{ env.FULL_DOMAIN }}/testing/lighthouse-canary-flow/unpublished
-          uploadArtifacts: true # save results as an action artifacts
-          temporaryPublicStorage: true # upload lighthouse report to the temporary storage
+            https://${{ github.event.number }}.${{ env.DOMAIN }}/testing/lighthouse-canary-flow/unpublished
+          uploadArtifacts: true  # save results as an action artifacts
+          temporaryPublicStorage: true  # upload lighthouse report to the temporary storage
       - name: Interpolate comment text
         id: text
         uses: actions/github-script@v6