Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact(ci): extract reusable workflow #1496

Closed
wants to merge 13 commits into from
Closed

refact(ci): extract reusable workflow #1496

wants to merge 13 commits into from

Conversation

gunar
Copy link
Contributor

@gunar gunar commented Feb 27, 2023

This PR DRYes the CI job that builds the React App. Similar code was being repeated in pull-request.yml, push-main.yml, and push-production.yml, and according to the rule of three it's time to refactor it.

The refactoring was not the sole goal though. This is a step towards #1442. In order to roll back a failed deployment, we have to actually roll forward. This means re-build (or possibly pull from cache) the frontend and any other dependencies. So really this PR came into existence to avoid adding yet another place (it'd be the 4th place) where CI builds the react app.

Rolling back failed deployments (#1442) will unblock scheduled production deployments (#1409).

@gunar gunar self-assigned this Feb 27, 2023
@gunar gunar force-pushed the g/extract-workflow branch 6 times, most recently from 87b6ea0 to acc782f Compare February 28, 2023 01:22
@gunar gunar force-pushed the g/extract-workflow branch from acc782f to 1ece378 Compare February 28, 2023 01:23
@github-actions
Copy link

github-actions bot commented Feb 28, 2023

Pizza

Deployed 836fd48 to https://1496.planx.pizza.

Useful links:

@github-actions
Copy link

github-actions bot commented Feb 28, 2023

Lighthouse

buckinhamshire/FOIYNPP testing/canary
performance 0.24 - 0.25 = -0.01 0.31 - 0.34 = -0.03
accessibility 1 - 1 = 0.00 1 - 1 = 0.00
best-practices 1 - 0.92 = 0.08 0.83 - 0.83 = 0.00
seo 0.88 - 0.89 = -0.01 0.89 - 0.92 = -0.03
pwa 0.7 - 0.7 = 0.00 0.7 - 0.7 = 0.00

@gunar gunar force-pushed the g/extract-workflow branch from db72887 to 9da0fb6 Compare February 28, 2023 15:40
@gunar gunar requested a review from a team February 28, 2023 19:53
@gunar gunar removed their assignment Feb 28, 2023
@DafyddLlyr
Copy link
Contributor

Closed in favour of this Trello ticket as this is now stale and de-prioritised.

@DafyddLlyr DafyddLlyr closed this Jul 25, 2023
@DafyddLlyr DafyddLlyr deleted the g/extract-workflow branch July 25, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants