-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refact(ci): extract reusable workflow #1496
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunar
force-pushed
the
g/extract-workflow
branch
6 times, most recently
from
February 28, 2023 01:22
87b6ea0
to
acc782f
Compare
gunar
force-pushed
the
g/extract-workflow
branch
from
February 28, 2023 01:23
acc782f
to
1ece378
Compare
gunar
force-pushed
the
g/extract-workflow
branch
from
February 28, 2023 15:40
db72887
to
9da0fb6
Compare
DafyddLlyr
approved these changes
Mar 6, 2023
Closed in favour of this Trello ticket as this is now stale and de-prioritised. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR DRYes the CI job that builds the React App. Similar code was being repeated in
pull-request.yml
,push-main.yml
, andpush-production.yml
, and according to the rule of three it's time to refactor it.The refactoring was not the sole goal though. This is a step towards #1442. In order to roll back a failed deployment, we have to actually roll forward. This means re-build (or possibly pull from cache) the frontend and any other dependencies. So really this PR came into existence to avoid adding yet another place (it'd be the 4th place) where CI builds the react app.
Rolling back failed deployments (#1442) will unblock scheduled production deployments (#1409).