Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Automatically grant users access to the "Templates" team #2291

Merged
merged 5 commits into from
Oct 12, 2023
Merged

feat: Automatically grant users access to the "Templates" team #2291

merged 5 commits into from
Oct 12, 2023

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Oct 9, 2023 •
edited
Loading

What does this PR do?

  • Using a trigger, automatically adds new users to the "Templates" team
  • Removes the responsibility for handling this end from the frontend
  • Adds E2E test coverage of this new behaviour
  • Adds basic tests for canUserEditTeam() logic in UserStore

@DafyddLlyr
Copy link
Contributor Author

Automatically add all new users to the "Templates" team

@DafyddLlyr DafyddLlyr force-pushed the dp/automatically-grant-templates-access branch from 276b700 to a5d6cf2 Compare October 9, 2023 21:58
@DafyddLlyr DafyddLlyr force-pushed the dp/automatically-grant-templates-access branch from a5d6cf2 to 05879d3 Compare October 9, 2023 22:03
@DafyddLlyr DafyddLlyr marked this pull request as ready for review October 10, 2023 08:17
@DafyddLlyr DafyddLlyr requested a review from a team October 10, 2023 08:17
@DafyddLlyr DafyddLlyr force-pushed the dp/automatically-grant-templates-access branch from d0e14f9 to 712f916 Compare October 10, 2023 08:26
@github-actions
Copy link

github-actions bot commented Oct 10, 2023 •
edited
Loading

Removed vultr server and associated DNS entries

jessicamcinchak
jessicamcinchak reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected for me when adding a new user, but left a comment below about existing users !

hasura.planx.uk/migrations/1696884217237_grant_new_user_template_team_access/up.sql Show resolved Hide resolved
@DafyddLlyr DafyddLlyr merged commit f2ec92f into main Oct 12, 2023
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/automatically-grant-templates-access branch October 12, 2023 08:19
DafyddLlyr added a commit that referenced this pull request Oct 13, 2023
@DafyddLlyr
feat: Automatically grant users access to the "Templates" team (#2291)
6e3e56e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicamcinchak jessicamcinchak jessicamcinchak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DafyddLlyr @jessicamcinchak