test: Cover error handling cases in API tests (1/2) #2466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
DafyddLlyr
commented
Nov 21, 2023
| @@ -7,7 +7,6 @@ import { Flow } from "../../../types"; | |||
| const copyPortalAsFlow = async (flowId: string, portalNodeId: string) => { | |||
| // fetch the parent flow data | |||
| const flow = await getFlowData(flowId); | |||
| if (!flow) throw Error("Unknown flowId"); | |||
There was a problem hiding this comment.
This was redundant and unreachable, this exception is already thrown inside getFlowData()
DafyddLlyr
commented
Nov 21, 2023
| @@ -44,7 +45,7 @@ export async function sendToEmail( | |||
| // Prepare email template | |||
| const config: EmailSubmissionNotifyConfig = { | |||
| personalisation: { | |||
| serviceName: flowName || "PlanX", | |||
There was a problem hiding this comment.
This was also unreachable - all flows must have names.
DafyddLlyr
commented
Nov 21, 2023
| @@ -54,12 +55,7 @@ export async function sendToEmail( | |||
|
|
|||
| // Send the email | |||
| const response = await sendEmail("submit", sendToEmail, config); | |||
| if (response?.message !== "Success") { | |||
There was a problem hiding this comment.
Again, this code was unreachable - message is only set to "Success" and nothing else.
jessicamcinchak
approved these changes
Nov 29, 2023
| }); | ||
| await expect(sendEmail("save", TEST_EMAIL, mockConfig)).rejects.toThrow(); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
These are super nice & clear 🙌
* test: More coverage updates * fix: Linting * fix: Copy paste errors
DafyddLlyr
force-pushed
the
dp/bump-api-coverage
branch
from
7428833 to
e347881
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
API test coverage change in #2466 & #2482