test: Cover error handling cases in API tests (2/2) #2482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
jessicamcinchak
approved these changes
Nov 29, 2023
| @@ -37,6 +37,18 @@ describe("BOPS payload admin endpoint", () => { | |||
| .expect(403); | |||
| }); | |||
|
|
|||
| it("returns an error if the XML generation fails", async () => { | |||
There was a problem hiding this comment.
nit: title of this test doesn't match what it's doing ?
| @@ -40,6 +40,22 @@ describe("Digital Planning Application payload admin endpoint", () => { | |||
| .expect(403); | |||
| }); | |||
|
|
|||
| it("returns an error if the XML generation fails", async () => { | |||
There was a problem hiding this comment.
same as above - update to "returns an error if the _payload_ generation fails" ?
DafyddLlyr
added a commit
that referenced
this pull request
Nov 29, 2023
* test: More coverage updates * fix: Linting * fix: Copy paste errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on from #2466 - please see this PR for details.