Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Drop BOPS_SUBMISSION_URL_* env vars in favour of DB values #2504

Merged
merged 4 commits into from
Dec 1, 2023
Merged

chore: Drop BOPS_SUBMISSION_URL_* env vars in favour of DB values #2504

merged 4 commits into from
Dec 1, 2023

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Nov 30, 2023 •
edited
Loading

What does this PR do?

  • Drop BOPS_SUBMISSION_URL_* env vars
  • Drop BOPS_API_ROOT_DOMAIN env vars
  • Read these values from the DB instead

Why?

  • Medway require their BOPS env added to PlanX and it now seems like a perfect time to tidy this up a little!

Depends on theopensystemslab/planx-core#212

Before merging this I'd be grateful for another pair of eyes on db values now populated on prod and staging. This query is giving me the expected results -

query GetBopsSubmissionURLs {
  teams(where: {integrations: {team_id: {_is_null: false}}}) {
    slug
    integrations {
      production_bops_submission_url
      staging_bops_submission_url
    }
  }
}

Once merged I'll also remove these from the real .env files on S3 also 👌

DafyddLlyr
DafyddLlyr commented Nov 30, 2023
View reviewed changes
api.planx.uk/.env.test.example
@@ -24,7 +24,6 @@ HASURA_GRAPHQL_URL=http://hasura:8080/v1/graphql
HASURA_PLANX_API_KEY=👻

# Integrations
BOPS_API_ROOT_DOMAIN=👻
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This env var can also be tidied up 🗑️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very satisfying ✂️

@DafyddLlyr DafyddLlyr marked this pull request as draft December 1, 2023 07:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023 •
edited
Loading

Removed vultr server and associated DNS entries

jessicamcinchak
jessicamcinchak approved these changes Dec 1, 2023
View reviewed changes
e2e/tests/api-driven/src/invite-to-pay/helpers.ts
},
);
};

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

api.planx.uk/.env.test.example
@@ -24,7 +24,6 @@ HASURA_GRAPHQL_URL=http://hasura:8080/v1/graphql
HASURA_PLANX_API_KEY=👻

# Integrations
BOPS_API_ROOT_DOMAIN=👻
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very satisfying ✂️

@DafyddLlyr DafyddLlyr requested a review from a team December 1, 2023 16:44
@DafyddLlyr DafyddLlyr marked this pull request as ready for review December 1, 2023 16:44
@DafyddLlyr DafyddLlyr merged commit 9a98dfd into dp/team-integrations-table Dec 1, 2023
10 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/remove-bops-env-vars branch December 1, 2023 17:24
@DafyddLlyr DafyddLlyr restored the dp/remove-bops-env-vars branch December 19, 2023 15:37
@DafyddLlyr DafyddLlyr mentioned this pull request Dec 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicamcinchak jessicamcinchak jessicamcinchak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DafyddLlyr @jessicamcinchak