chore(e2e): Update dependencies for Playwright tests #2579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessicamcinchak
approved these changes
Dec 19, 2023
DafyddLlyr
commented
Dec 19, 2023
| "additionalAssertFunctionNames": ["expectSections"] | ||
| } | ||
| ], | ||
| "playwright/no-networkidle": "warn" |
There was a problem hiding this comment.
This one is a bit of a known outstanding issue - ideally we wouldn't rely on the networkidle status but I didn't want to get sidetracked into unpicking this just now (and it's unrelated to failure on other branch).
Docs: https://playwright.dev/docs/api/class-page#page-wait-for-load-state
|
Removed vultr server and associated DNS entries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick attempt to rule this out as a blocker on #2575 without creating additional noise 👌
Regression tests passing on branch ✅