Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): Update dependencies for Playwright tests #2579

Merged
merged 4 commits into from
Dec 19, 2023
Merged

chore(e2e): Update dependencies for Playwright tests #2579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b84545e
chore: Update packages
DafyddLlyr Dec 19, 2023
598efb2
chore: Run pnpm lint:fix
DafyddLlyr Dec 19, 2023
5a4a79b
chore: Handle outstanding lint rules
DafyddLlyr Dec 19, 2023
b23c1f5
chore: Custom GitHub test reporter
DafyddLlyr Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion e2e/tests/ui-driven/.eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
{
"extends": ["../../.eslintrc", "plugin:playwright/playwright-test"]
"extends": ["../../.eslintrc", "plugin:playwright/playwright-test"],
"rules": {
"playwright/expect-expect": [
"error",
{
"additionalAssertFunctionNames": ["expectSections"]
}
],
"playwright/no-networkidle": "warn"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is a bit of a known outstanding issue - ideally we wouldn't rely on the networkidle status but I didn't want to get sidetracked into unpicking this just now (and it's unrelated to failure on other branch).

Docs: https://playwright.dev/docs/api/class-page#page-wait-for-load-state

}
}
14 changes: 7 additions & 7 deletions e2e/tests/ui-driven/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,19 +9,19 @@
},
"dependencies": {
"@opensystemslab/planx-core": "git+https://github.com/theopensystemslab/planx-core#95b54b3",
"axios": "^1.6.0",
"axios": "^1.6.2",
"dotenv": "^16.3.1",
"eslint": "^8.44.0",
"eslint": "^8.56.0",
"graphql": "^16.8.1",
"graphql-request": "^6.1.0",
"isomorphic-fetch": "^3.0.0",
"jsonwebtoken": "^9.0.1",
"serve": "^14.2.0",
"uuid": "^9.0.0"
"jsonwebtoken": "^9.0.2",
"serve": "^14.2.1",
"uuid": "^9.0.1"
},
"devDependencies": {
"@playwright/test": "^1.39.0",
"@playwright/test": "^1.40.1",
"@types/node": "18.16.1",
"eslint-plugin-playwright": "^0.12.0"
"eslint-plugin-playwright": "^0.20.0"
}
}
2 changes: 1 addition & 1 deletion e2e/tests/ui-driven/playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const config: PlaywrightTestConfig = {
/* Opt out of parallel tests */
workers: 1,
/* Reporter to use. See https://playwright.dev/docs/test-reporters */
reporter: "line",
reporter: process.env.CI ? "github" : "line",
use: {
/* Maximum time each action such as `click()` can take. Defaults to 0 (no limit). */
actionTimeout: 0,
Expand Down
Loading
Loading