-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Set httpOnly
flag in cookie
#2591
Conversation
Removed vultr server and associated DNS entries |
afa1890
to
c14c9d3
Compare
01c2694
to
e7ffb80
Compare
e7ffb80
to
d68c267
Compare
@@ -25,7 +25,7 @@ | |||
"@tiptap/extension-history": "^2.0.3", | |||
"@tiptap/extension-image": "^2.0.3", | |||
"@tiptap/extension-italic": "^2.0.3", | |||
"@tiptap/extension-link": "^2.0.3", | |||
"@tiptap/extension-link": "^2.1.13", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the issue that was giving me so much grief (causing E2E tests to fail) - I managed to recreate on the Pizza whilst testing 🤯
I still really don't get the relationship here or what the real root cause is, but it was code for this extension in RichTextInput.tsx
which was causing issues.
I'll pick up a PR to revert #2589 shortly.
httpOnly
flag in cookiehttpOnly
flag in cookie
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting to the bottom of this one, diagram is super helpful! Testing steps all working as expected for me, happy to test again this afternoon on staging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! It sounds like it was a frustrating piece of work but awesome you got to the bottom of it 🥳
This reverts commit 01bcb76.
This reverts commit 01bcb76.
What does this PR do?
httpOnly
flag to our auth cookieHow does auth work?
I'll move this diagram to a page in Notion as well, but this is a helpful diagram for making sense of the changes here -
How do I test this?
Access-Control-Allow-Origin
header is set tohttps://2591.planx.pizza
when hitting/user/me
as part of the auth process(Once changes merged to staging)