Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Apply theme colours across app #2658

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

ianjon3s
Copy link
Contributor

What does this pull request do?

Applies new theme colours created in #2646 across the components and UI of the app.

Notes:

  • The content component is correctly selecting the appropriate colours for contrast link text (default: link colour, plus black or white depending on contrast), however I was not able to get this to function in the notice component due to overriding specificity set in the theme. This is also a current issue on the live services. For simplicity I've set the link text to inherit paragraph text colour in this component, and will revisit this in a future PR.
  • As we are now using both dark and light button background colours, I've adjusted the tonal offset to 0.1, ensuring that darkening a light background colour on hover does not reduce it's contrast with dark overlay by too much a margin.

Copy link

github-actions bot commented Jan 12, 2024

Removed vultr server and associated DNS entries

@DafyddLlyr
Copy link
Contributor

  • The content component is correctly selecting the appropriate colours for contrast link text (default: link colour, plus black or white depending on contrast), however I was not able to get this to function in the notice component due to overriding specificity set in the theme. This is also a current issue on the live services. For simplicity I've set the link text to inherit paragraph text colour in this component, and will revisit this in a future PR.

Thanks for the heads up here - it would be good to get to the bottom of this but no rush if it's currently an outstanding issue on production also.

@DafyddLlyr DafyddLlyr merged commit c283603 into main Jan 17, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the ian/apply-new-theme-colours branch January 17, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants