Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): Change first-child to nth-child(1) #2668

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Jan 16, 2024

What does this PR do?

  • Fixes noisy React warning (in dev-mode console, and tests) warning about use of :first-child selector
  • Replaces with :nth-child(1) selector

image

Copy link

github-actions bot commented Jan 16, 2024

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr force-pushed the dp/first-of-type-css branch from 44ccca2 to 588dbec Compare January 17, 2024 08:19
@DafyddLlyr DafyddLlyr changed the title fix(css): Change first-child to first-of-type wip(css): Change first-child to first-of-type Jan 17, 2024
@DafyddLlyr DafyddLlyr force-pushed the dp/first-of-type-css branch from 588dbec to 63754c7 Compare January 17, 2024 11:00
@DafyddLlyr DafyddLlyr changed the title wip(css): Change first-child to first-of-type wip(css): Change first-child to nth-child(1) Jan 17, 2024
@DafyddLlyr DafyddLlyr changed the title wip(css): Change first-child to nth-child(1) fix(css): Change first-child to nth-child(1) Jan 22, 2024
@DafyddLlyr DafyddLlyr requested a review from a team January 22, 2024 16:07
@DafyddLlyr DafyddLlyr marked this pull request as ready for review January 22, 2024 16:07
Copy link
Contributor

@Mike-Heneghan Mike-Heneghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @DafyddLlyr!

It's working as expected for me 😌

@DafyddLlyr DafyddLlyr merged commit 7c22937 into main Jan 22, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/first-of-type-css branch January 22, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants