feat: Wire up favicon form #2680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
commented
Jan 19, 2024
| <InputRowItem width={50}> | ||
| <PublicFileUploadButton /> | ||
| <InputRowItem width={formik.values.favicon ? 90 : 50}> | ||
| <ImgInput |
There was a problem hiding this comment.
I've updated this to use the wrapper ImgInput component which gives us a preview and a way to remove the image.
I'll open up a very small follow-on PR to make this change to the Logo form shortly to keep this visually and behaviorally consistent.
DafyddLlyr
commented
Jan 19, 2024
| @@ -39,8 +60,16 @@ export const FaviconForm: React.FC = () => { | |||
| input={ | |||
| <InputRow> | |||
| <InputRowLabel>Favicon:</InputRowLabel> | |||
| <InputRowItem width={50}> | |||
| <PublicFileUploadButton /> | |||
| <InputRowItem width={formik.values.favicon ? 90 : 50}> | |||
There was a problem hiding this comment.
Resizing this on upload looks better to me than keeping it wide the whole time - very open to opinions here if this jump in not consistent / a bit weird @ianjon3s
DafyddLlyr
commented
Jan 19, 2024
| @@ -139,7 +139,7 @@ const DesignSettings: React.FC = () => { | |||
| <ThemeAndLogoForm team={team} onSuccess={() => setOpen(true)} /> | |||
| <ButtonForm team={team} onSuccess={() => setOpen(true)} /> | |||
| <TextLinkForm team={team} onSuccess={() => setOpen(true)} /> | |||
| <FaviconForm /> | |||
| <FaviconForm team={team} onSuccess={() => setOpen(true)} /> | |||
There was a problem hiding this comment.
There's a little repetition with some of these props and form behaviours - I'll look at a small follow on PR to try and tidy this up 👌
|
Removed vultr server and associated DNS entries |
Mike-Heneghan
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
/previewand/unpublishedroutes if one is set in DB for teamTo test
/previewand/unpublishedroutesDemo: https://2680.planx.pizza/barking-and-dagenham/backup-dec23-article4-barkinganddagenham-manual-constraints/preview?analytics=false