feat: scroll to feedback view on view change #2716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
DafyddLlyr
approved these changes
Jan 31, 2024
| @@ -364,7 +375,11 @@ const Feedback: React.FC = () => { | |||
| } | |||
| } | |||
|
|
|||
| return <Feedback />; | |||
| return ( | |||
| <div ref={feedbackComponentRef}> | |||
There was a problem hiding this comment.
nit: Throughout the codebase we tend to use MUI components, could we change this div to a Box for consistency?
Mike-Heneghan
force-pushed
the
mh/wire-up-feedback-forms
branch
from
9d86a34 to
5c8a4c3
Compare
Mike-Heneghan
force-pushed
the
mh/scroll-to-feedback
branch
from
f2a6b23 to
8735f3e
Compare
Mike-Heneghan
added a commit
that referenced
this pull request
Feb 1, 2024
- As per: #2716 (comment) - More consistent within the codebase to use Box rather than div
Mike-Heneghan
force-pushed
the
mh/scroll-to-feedback
branch
from
8735f3e to
cdc5118
Compare
DafyddLlyr
reviewed
Feb 1, 2024
Comment on lines
105
to
107
| case "banner": | ||
| return false; | ||
| case "thanks": | ||
| return false; |
There was a problem hiding this comment.
Suggested change
| case "banner": | |
| return false; | |
| case "thanks": | |
| return false; | |
| case "banner": | |
| case "thanks": | |
| return false; |
There was a problem hiding this comment.
nit: Sorry - small nitpick but a bit more readable / consistent with rest of codebase.
Comment on lines
+39
to
+48
| const feedbackComponentRef = useRef<HTMLDivElement | null>(null); | ||
|
|
||
| useEffect(() => { | ||
| if (currentFeedbackView === "input") { | ||
| feedbackComponentRef.current?.scrollIntoView({ | ||
| behavior: "smooth", | ||
| block: "start", | ||
| }); | ||
| } | ||
| }, [currentFeedbackView]); |
There was a problem hiding this comment.
A custom hook might be a slightly cleaner way of reusing this logic across both components / files?
Something like -
const useScrollIntoView = (currentFeedbackView) => {
const feedbackComponentRef = useRef<HTMLDivElement | null>(null);
const shouldScrollToView = () => **logic here**
useEffect(() => {
if (shouldScrollToView()) {
feedbackComponentRef.current?.scrollIntoView({
behavior: 'smooth',
block: 'start',
});
}
}, [currentFeedbackView]);
return feedbackComponentRef;
};Alternatively just a wrapper for the feedback components with this logic could work also. If this makes things more complex or there's something I'm missing here no sweat!
Mike-Heneghan
force-pushed
the
mh/wire-up-feedback-forms
branch
2 times, most recently
from
09c59ee to
94537fa
Compare
Mike-Heneghan
added a commit
that referenced
this pull request
Feb 2, 2024
- As per: #2716 (comment) Co-authored-by: Dafydd Llŷr Pearson <[email protected]>
- When the currentFeedbackView changes the component can render partially off screen - Add ref and useEffect to scroll down when it changes and isn't the "banner" or "thanks"
- As per: #2716 (comment) - More consistent within the codebase to use Box rather than div
- When user's select "yes" or "no" and the form is rendered scroll to show the full form
…crolled to - The logical condition in the useEffect was somewhat hard to read - Added a case statement to make the logic more explicit / readable
- As per: #2716 (comment) Co-authored-by: Dafydd Llŷr Pearson <[email protected]>
Mike-Heneghan
force-pushed
the
mh/scroll-to-feedback
branch
from
4337884 to
e0aa9f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Main Feedback:
MoreInfo Feedback:
Why
Risks
Screen recording
Before:
Screen.Recording.2024-01-30.at.16.53.09.mov
After:
Screen.Recording.2024-02-01.at.15.35.56.mov