feat: Add _requestedFiles key to Passport
#2763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
DafyddLlyr
commented
Feb 7, 2024
| @@ -41,7 +41,7 @@ export const makeData = <T>( | |||
| props: any, | |||
| value: T, | |||
| overwriteKey?: string, | |||
| ): {} | { data: Record<string, T> } => { | |||
| ): Record<string, never> | { data: Record<string, T> } => { | |||
DafyddLlyr
force-pushed
the
dp/requested-files-v2
branch
from
fd3927e to
b7b31fd
Compare
| @@ -62,7 +62,7 @@ function Component(props: any) { | |||
| </InputRow> | |||
| <InputRow> | |||
| <Input | |||
| // required | |||
| required | |||
There was a problem hiding this comment.
I agree this should be correct behavior - but I wonder if this will break any discretionary submission services like building control forms or something? Hopefully not / easy enough to fix forward if we find it does I guess? I don't necessarily think we should be putting as much proactive effort into find/replace etc outside of "standard" services?
DafyddLlyr
force-pushed
the
dp/requested-files-v2
branch
from
b7b31fd to
5513cd9
Compare
DafyddLlyr
force-pushed
the
dp/requested-files-v2
branch
from
3f04d20 to
f74f9da
Compare
jessicamcinchak
approved these changes
Feb 8, 2024
This was referenced Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior art - #2755
What does this PR do?
_requestedFileTo do