feat: query submission_services_summary and log result #2885
Conversation
There was a problem hiding this comment.
Rather than be in the lib folder I've abstracted this into it's own file.
This was for readability in the Submission but also because I think it'll make test setup much easier later as the query can be more easily mocked with this approach.
Open to feedback on this though!
|
Removed vultr server and associated DNS entries |
...anx.uk/src/pages/FlowEditor/components/Settings/Submissions/submissionDataTypesAndQueries.ts
Outdated
Show resolved
Hide resolved
Mike-Heneghan
force-pushed
the
mh/setup-types-and-query
branch
from
edd3e1b to
41eba19
Compare
Mike-Heneghan
changed the base branch from
main
to
mh/update-submissions-view-to-camel-case
Mike-Heneghan
changed the base branch from
mh/update-submissions-view-to-camel-case
to
main
Mike-Heneghan
force-pushed
the
mh/setup-types-and-query
branch
from
41eba19 to
74c5ee3
Compare
- Setup up the types and function to query the submission_services_summary for the pertinent data - For now simply log the data out in the console
Mike-Heneghan
force-pushed
the
mh/setup-types-and-query
branch
from
74c5ee3 to
09e5c83
Compare
editor.planx.uk/src/pages/FlowEditor/components/Settings/Submissions/index.tsx
Outdated
Show resolved
Hide resolved
...anx.uk/src/pages/FlowEditor/components/Settings/Submissions/submissionDataTypesAndQueries.ts
Outdated
Show resolved
Hide resolved
...anx.uk/src/pages/FlowEditor/components/Settings/Submissions/submissionDataTypesAndQueries.ts
Outdated
Show resolved
Hide resolved
| useEffect(() => { | ||
| if (flowSlug && teamSlug) { | ||
| fetchSubmittedApplications(flowSlug, teamSlug) | ||
| .then((result) => setApplications(result.submission_services_summary)) | ||
| .catch((error) => { | ||
| setError(error); | ||
| }); | ||
| } | ||
| }, [flowSlug, teamSlug]); |
There was a problem hiding this comment.
Data fetching from within components is probably not handled very consistently currently in the application. I would think most data queries are handled at the route level, set to the store, and then updated from there.
In this instance, I'd recommend you take a look at the useQuery() hook which allows access to nice loading and error variables which can be used by the UI - this might allow you to simplify some of this code.
- As per: #2885 (comment) - As per: #2885 (comment) Co-authored-by: Dafydd Llŷr Pearson <[email protected]>
- As per: #2885 (comment) - Separating concerns for readability / ease fo testing
Mike-Heneghan
force-pushed
the
mh/setup-types-and-query
branch
from
c47332f to
30b4c0c
Compare
There was a problem hiding this comment.
Really nice refactor here in 30b4c0c @Mike-Heneghan 👌
Cleaner separation between data fetching and view will hopefully make things a whole lot simpler and more maintainable here. Also easier for tests, and handover to @ianjon3s for design 👏
When it came to the Feedback work I never felt like I quite got the componentisation right but I'm really hopeful this pattern will make things easier like you say. Thanks again for all your suggestions @DafyddLlyr they very much led to 30b4c0c 🙌 |
What
submission_services_summaryfor the pertinent datasessionIdof fetched applications.Why