Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: query submission_services_summary and log result #2885
feat: query submission_services_summary and log result #2885
Changes from 1 commit
09e5c83
61af3a7
cc2eb17
30b4c0c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data fetching from within components is probably not handled very consistently currently in the application. I would think most data queries are handled at the route level, set to the store, and then updated from there.
In this instance, I'd recommend you take a look at the
useQuery()
hook which allows access to nice loading and error variables which can be used by the UI - this might allow you to simplify some of this code.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than be in the
lib
folder I've abstracted this into it's own file.This was for readability in the
Submission
but also because I think it'll make test setup much easier later as the query can be more easily mocked with this approach.Open to feedback on this though!