Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update view JSON object keys to camel case #2886

Merged
merged 1 commit into from
Mar 14, 2024
Merged

chore: update view JSON object keys to camel case #2886

merged 1 commit into from
Mar 14, 2024

Conversation

Mike-Heneghan
Copy link
Contributor

What

  • Update the JSON objects in the view to have camel case keys

Why

  • Avoid case mismatches with types in the FE

@Mike-Heneghan Mike-Heneghan requested a review from a team March 14, 2024 10:04
@Mike-Heneghan Mike-Heneghan self-assigned this Mar 14, 2024
@Mike-Heneghan Mike-Heneghan mentioned this pull request Mar 14, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 14, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

DafyddLlyr
DafyddLlyr approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Mike-Heneghan Mike-Heneghan merged commit 3b0bdd7 into main Mar 14, 2024
12 checks passed
@Mike-Heneghan Mike-Heneghan deleted the mh/update-submissions-view-to-camel-case branch March 14, 2024 12:20
@Mike-Heneghan
Copy link
Contributor Author

Allow service owners and product owners to see that an application has been sent successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DafyddLlyr DafyddLlyr DafyddLlyr approved these changes

Assignees

@Mike-Heneghan Mike-Heneghan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mike-Heneghan @DafyddLlyr