chore: rename export zip to {flow-slug}-{session-id}.zip
#2893
Conversation
|
Removed vultr server and associated DNS entries |
|
Zip is working as expected on pizza here, but invite to pay is broken - Can't spot where I've missed a session type update, going to switch tasks for a bit and come back with fresh eyes later. |
| this.zip = new AdmZip(); | ||
| // make a tmp directory to avoid file name collisions if simultaneous applications | ||
| this.tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), sessionId)); | ||
| this.filename = path.join(__dirname, `ripa-test-${sessionId}.zip`); | ||
| this.filename = path.join(__dirname, `${flowSlug}-${sessionId}.zip`); |
There was a problem hiding this comment.
This gives me the following on Pizza -
Are you getting this also? Could we drop __dirname here?
There was a problem hiding this comment.
dirname only occurs on docker envs as I understand it (so local & pizzas), should be automatically omitted on staging / prod !
There was a problem hiding this comment.
eg http://api.editor.planx.dev/admin/session/d4d9249a-dc1e-4996-9bfc-15fd3adab242/zip returns plain ripa-test-{sessionId}.zip
There was a problem hiding this comment.
Perfect, thanks for clarifying! Makes sense considering we don't get this on staging / prod.
When downloading zips via "Send to email", councils want to more clearly see which service a zip is associated with for reporting.
Relies on theopensystemslab/planx-core#328
Testing:
teams.submission_email- confirm the zip is named as expected on download