Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Tab styling for editor browser preview / history #3020

Merged
merged 5 commits into from
Apr 23, 2024

Conversation

ianjon3s
Copy link
Contributor

@ianjon3s ianjon3s commented Apr 16, 2024

What does this PR do?

  • Adds tabbed menu to the browser preview in the editor sidebar to allow for switching between browser preview and history views
  • Updates React states for tab functionality

Copy link

github-actions bot commented Apr 16, 2024

Removed vultr server and associated DNS entries

@ianjon3s ianjon3s force-pushed the ian/undo-ui-update branch from b8b34e4 to 17bd0df Compare April 17, 2024 08:17
@ianjon3s ianjon3s force-pushed the ian/undo-ui-update branch from c8f8bce to 23ab62f Compare April 23, 2024 11:41
@ianjon3s ianjon3s marked this pull request as ready for review April 23, 2024 12:00
Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ! Vultr is failing here because pizza secrets have been rotated since this PR was originally opened. Since we all paired on this earlier, comfy with it getting merged with Vultr failing so feel free to check the override CI rules box or whatever and I'll hook my changes into the "History" tab once on main 🙂

@ianjon3s ianjon3s merged commit 19d23ec into main Apr 23, 2024
11 of 12 checks passed
@ianjon3s ianjon3s deleted the ian/undo-ui-update branch April 23, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants