feat: Inline loading indicator for address lookup #3136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
jessicamcinchak
approved these changes
May 10, 2024
This was referenced May 13, 2024
ianjon3s
force-pushed
the
ian/fetching-address-data-update
branch
from
0c1f098 to
d60cd3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
To both build on the work in progress here: #3022,
and also as an improvement to the current setup — updates the progress indicator to be inline with the continue button.
Changes:
inlineprop added toDelayedLoadingIndicator, making it easier to use either as a full screen takeover or as part of page contentPreview:
Test:
https://3136.planx.pizza/testing/address-lookup/published