feat(backend): Toggle flow online or offline #3170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Hasura Change Summary compared a subset of table metadata including permissions: Tracked Tables (2)Updated Tables (1)
|
|
Removed vultr server and associated DNS entries |
DafyddLlyr
force-pushed
the
dp/flow-offline-online
branch
from
eade504 to
940a2c0
Compare
DafyddLlyr
changed the title
DafyddLlyr
force-pushed
the
dp/flow-offline-online
branch
from
940a2c0 to
3856c52
Compare
DafyddLlyr
commented
May 21, 2024
There was a problem hiding this comment.
Looking good & thorough (appreciate all the testing here), but a few questions around domain assumptions here!
Plus one more point I'm thinking about for "Next steps..."
- Only write analytics records when URL does not have param
?analytics=falseAND when flow status is "online" !- If we can just skip writing the tracking events altogether when flows are "offline", that should save us having to add joins to
flow_status_historyto the analytics views? - This would similarly assume that existing flows are online by default & new ones are offline I think?
- If we can just skip writing the tracking events altogether when flows are "offline", that should save us having to add joins to
e2e/tests/api-driven/src/flowStatusHistory/flowStatusHistory.feature
Outdated
Show resolved
Hide resolved
This is an elegant and clever solution - very much on board! Much easier than a tricky join and actually matches the model we want and users would expect (analytics are collected for "online" services only). |
jessicamcinchak
approved these changes
May 21, 2024
DafyddLlyr
added a commit
to theopensystemslab/planx-core
that referenced
this pull request
May 21, 2024
Please see theopensystemslab/planx-new#3170 for context. This PR adds a helper method to toggle the status of the flow. This is used in E2E tests, and will be called by Editors in the frontend.
DafyddLlyr
force-pushed
the
dp/flow-offline-online
branch
2 times, most recently
from
eec4867 to
29a71ed
Compare
- Setup table and populate - Setup trigger - Add status column to flows, setup permissions
- This has some implications for e2e tests that are best handled in isolation in another PR
DafyddLlyr
force-pushed
the
dp/flow-offline-online
branch
from
8a462a6 to
88939f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
flows.statuscolumn, which can be one of "online" or "offline"flow_status_historyaudit table which could be used to check the status of a flow at a given point in time, and could be used to filter analytics if we wished to do sotack_flow_status_history()which has the following behaviour -UPDATEtoflow.statusorINSERTtoflowsflow_status_historyrecord, and opens new one with toggled statusTesting
Next steps...
Regression tests passing here - https://github.com/theopensystemslab/planx-new/actions/runs/9162033526