chore: split residential unit List component schemas into six options #3250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
jessicamcinchak
commented
Jun 6, 2024
| @@ -181,7 +181,7 @@ const Root = () => { | |||
| sx={{ width: "100%" }} | |||
| data-testid="list-add-button" | |||
| > | |||
| + Add a new {schema.type.toLowerCase()} description | |||
| + Add another {schema.type.toLowerCase()} description | |||
There was a problem hiding this comment.
One of the GLA schemas has type: "New built residential unit", so "another" prevents "new new"
jessicamcinchak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schemas based on this flow: https://editor.planx.uk/opensystemslab/residential-units
See thread here: https://opensystemslab.slack.com/archives/C5Q59R3HB/p1717676834944659?thread_ts=1717416055.509189&cid=C5Q59R3HB
Also adjusts summary totals calculated
onSubmitto include both count of list items and sum of all units.Eventually, we'll want to calculate totals by tenure and unit type - but we should consider capturing the
val, rather thantextin the passport first.