-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: split residential unit List component schemas into six options #3250
Merged
+1,002
−87
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
fea1a67
split res unit schemas into six options
jessicamcinchak 115e48c
draft gla schema
jessicamcinchak f17f161
skip checklist field creation for now
jessicamcinchak 454ce96
adjust passport totals
jessicamcinchak d2aed30
adjust mock data
jessicamcinchak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,7 +43,7 @@ const mockPayload = { | |
"mockFn.two.email": "[email protected]", | ||
"mockFn.two.name": "Richard Parker", | ||
"mockFn.two.size": "Medium", | ||
"mockFn.count": 2, | ||
"mockFn.total.listItems": 2, | ||
}, | ||
}; | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73 changes: 0 additions & 73 deletions
73
editor.planx.uk/src/@planx/components/List/schemas/ResidentialUnits.ts
This file was deleted.
Oops, something went wrong.
72 changes: 72 additions & 0 deletions
72
editor.planx.uk/src/@planx/components/List/schemas/ResidentialUnits/Existing.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
import { Schema } from "../../model"; | ||
|
||
export const ResidentialUnitsExisting: Schema = { | ||
type: "Existing residential unit", | ||
fields: [ | ||
{ | ||
type: "question", | ||
data: { | ||
title: "What best describes the tenure of this unit?", | ||
fn: "tenure", | ||
options: [ | ||
{ id: "MH", data: { text: "Market housing", val: "MH" } }, | ||
{ | ||
id: "SAIR", | ||
data: { text: "Social, affordable or interim rent", val: "SAIR" }, | ||
}, | ||
{ | ||
id: "AHO", | ||
data: { text: "Affordable home ownership", val: "AHO" }, | ||
}, | ||
{ id: "SH", data: { text: "Starter homes", val: "SH" } }, | ||
{ | ||
id: "selfCustomBuild", | ||
data: { | ||
text: "Self-build and custom build", | ||
val: "selfCustomBuild", | ||
}, | ||
}, | ||
{ id: "other", data: { text: "Other", val: "other" } }, | ||
], | ||
}, | ||
}, | ||
{ | ||
type: "question", | ||
data: { | ||
title: "What best describes the type of this unit?", | ||
fn: "type", | ||
options: [ | ||
{ id: "house", data: { text: "House", val: "house" } }, | ||
{ | ||
id: "flat", | ||
data: { text: "Flat, apartment or maisonette", val: "flat" }, | ||
}, | ||
{ | ||
id: "sheltered", | ||
data: { text: "Sheltered housing", val: "sheltered" }, | ||
}, | ||
{ id: "studio", data: { text: "Studio or bedsit", val: "studio" } }, | ||
{ id: "cluster", data: { text: "Cluster flat", val: "cluster" } }, | ||
{ id: "other", data: { text: "Other", val: "other" } }, | ||
], | ||
}, | ||
}, | ||
{ | ||
type: "number", | ||
data: { | ||
title: "How many bedrooms does this unit have?", | ||
fn: "bedrooms", | ||
allowNegatives: false, | ||
}, | ||
}, | ||
{ | ||
type: "number", | ||
data: { | ||
title: "How many identical units does the description above apply to?", | ||
fn: "identicalUnits", | ||
allowNegatives: false, | ||
}, | ||
}, | ||
], | ||
min: 1, | ||
} as const; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the GLA schemas has
type: "New built residential unit"
, so "another" prevents "new new"