Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: List should record val, not text, in passport and calculate total units by development type when applicable #3263

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Jun 10, 2024

Why:

  • For residential units, we need to be able to breakdown the total sum of identical units by their development type
    • MathJS/Calculate can't do list iteration & grouping, so we're going to handle this onSubmit for any schemas that set a field with fn = development for now
  • In order to accomplish this, we also need the passport to record the val of the selected option if set, rather than its text
    • The val will also be useful later when populating the ODP Schema, as it fits our current pattern of looking up a description from value rather than the other way around
    • The inactive list view should still always display the human-readable text, even if a val is recorded in the passport

Changes

  • Updates existing schemas to set val where expected
  • Updates question & select inputs to record val || text (val is optional & text is required)
  • Adds additional summary statistic for total units by development type when applicable
  • Updates tests with "generic units" schema example to help illustrate expected stats

@jessicamcinchak jessicamcinchak changed the title fix: List items sholud record val, not text, in passport and calculate units by development type fix: List should record val, not text, in passport and calculate total units by development type when applicable Jun 10, 2024
Copy link

github-actions bot commented Jun 10, 2024

Removed vultr server and associated DNS entries

@jessicamcinchak jessicamcinchak marked this pull request as ready for review June 11, 2024 08:54
@jessicamcinchak jessicamcinchak requested a review from a team June 11, 2024 08:54
@jessicamcinchak jessicamcinchak merged commit 5929a12 into main Jun 11, 2024
12 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/list-passport-vals branch June 11, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant