Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new GLA schemas #3267

Merged
merged 19 commits into from
Jun 11, 2024

Conversation

augustlindemer
Copy link
Collaborator

Includes the following schemas:

  • GLA gained & lost structure
  • GLA existing and proposed uses
  • GLA building details
  • GLA communal spaces
  • GLA open spaces
  • GLA protected spaces

Copy link

github-actions bot commented Jun 11, 2024

Removed vultr server and associated DNS entries

@augustlindemer
Copy link
Collaborator Author

augustlindemer commented Jun 11, 2024

Strange bug: Existing and proposed uses do not allow me to enter any numbers into the GIA entry fields. Can't see any errors with the schema. Upon first creating the list component/selecting the schema I can provide input, but can't save. Upon reloading I can't put in anything. Issue seems exclusive to Existing and proposed uses.

Edit: Just realised I used . relationships for the variables, I recall this isn't supported yet. This is probably it!

{ id: "gained", data: { text: "Gained", val: "gained" } },
{ id: "lost", data: { text: "Lost", val: "lost" } },
],
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my first go at summing identical units by development type was only accounting for the previous three options, but I'll update it to work the same when gained & lost are options too 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also nit picky thing: you use loss in later schemas, but lost here as "development" options - are they actually different in legislation or can we standardise?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting. loss/gain is what the data hub has in their technical schema across categories (including resi units), so I updated the lost/gained to loss/gain.

data: {
title: "What is the existing gross internal floor area?",
units: "m²",
fn: "area.existing",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect these . separated fn are the source of your bug!

For now, I think we need to write all fn & val without separators - but I'll work on finding a fix to support this / try to wrap my head around why Daf may not have done it from the start !

Feel free to note "ideal" fn in comment at line ends like this so we don't forget:

fn: "areaExisting", // area.existing

Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great !! Thanks for getting all these in 🎉

@augustlindemer augustlindemer merged commit 85af90a into main Jun 11, 2024
12 checks passed
@augustlindemer augustlindemer deleted the augustlindemer-open-and-protected-spaces-GLA branch September 4, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants