Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ChecklistFieldInput for List component #3304

Merged
merged 12 commits into from
Jul 1, 2024
Merged

feat: ChecklistFieldInput for List component #3304

merged 12 commits into from
Jul 1, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Jun 20, 2024 •
edited
Loading

What does this PR do?

  • Introduces a ChecklistField for the List component
    • As with our other fields, this requires making the validation schema shared
  • Updates existing schemas to use checklists instead of a series of questions
  • Updates tests
  • Update flatten() logic to handle checklist responses
image

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 20, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr force-pushed the dp/list-component-checklist-field branch from 9d46d7d to b21c6d3 Compare June 24, 2024 12:37
@DafyddLlyr DafyddLlyr mentioned this pull request Jun 25, 2024
Merged
@DafyddLlyr DafyddLlyr force-pushed the dp/list-component-checklist-field branch 3 times, most recently from ac111f3 to f6b8d54 Compare June 25, 2024 15:44
@DafyddLlyr DafyddLlyr changed the title feat(wip): ChecklistFieldInput for List component feat: ChecklistFieldInput for List component Jun 26, 2024
@DafyddLlyr DafyddLlyr requested a review from a team June 26, 2024 09:01
@DafyddLlyr DafyddLlyr marked this pull request as ready for review June 26, 2024 09:02
ianjon3s
ianjon3s approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@ianjon3s ianjon3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist outputs with correct a11y markup and functions correctly on the front-end, with the exception of the bug addressed in #3316

@DafyddLlyr DafyddLlyr force-pushed the dp/list-component-checklist-field branch from 421acac to ac9c112 Compare June 26, 2024 10:31
jessicamcinchak
jessicamcinchak approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works exactly as I'd expect it to & records a list of my selected values in the passport !

Really nice List extension/addition 🙂

editor.planx.uk/src/@planx/components/List/Public/Context.tsx Show resolved Hide resolved
editor.planx.uk/src/@planx/components/List/utils.tsx Outdated Show resolved Hide resolved
editor.planx.uk/src/@planx/components/List/utils.tsx Show resolved Hide resolved
@DafyddLlyr DafyddLlyr mentioned this pull request Jun 27, 2024
Merged
DafyddLlyr added 11 commits June 28, 2024 11:59
@DafyddLlyr
feat: Make checklist validation shared
15ab3e5
@DafyddLlyr
feat: Import first schema with checklists for testing
36b6f87
@DafyddLlyr
feat: Handle arrays of responses (slightly crudely for now)
fdbec2e
@DafyddLlyr
feat: Basic ChecklistFieldInput setup
727f5f9 
- Still getting buggy behaviours with checkboxes, but not labels
@DafyddLlyr
fix: White backgrounds for checkboxes
d327451
@DafyddLlyr
test: Fix existing test cases
36d3674 
- Revisit this when taking a closer look at how best to handle checklist responses
@DafyddLlyr
feat: Handle list display in InactiveCard
d0e1a82
@DafyddLlyr
test: Add checklist and basic test coverage to existing Zoo schema
ec69004
@DafyddLlyr
chore: Update all schemas with checklists
2e940ae 
- Also replace questions for checklists
@DafyddLlyr
feat: Only flatten payload to required depth, in order to preserve ch…
96e74b3 
…ecklist answers
@DafyddLlyr
fix: Update list style to match SummaryList
cea11f8
@DafyddLlyr DafyddLlyr force-pushed the dp/list-component-checklist-field branch from 1bc4a92 to cea11f8 Compare June 28, 2024 11:02
@DafyddLlyr DafyddLlyr merged commit 2a095c0 into main Jul 1, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/list-component-checklist-field branch July 1, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianjon3s ianjon3s ianjon3s approved these changes

@jessicamcinchak jessicamcinchak jessicamcinchak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DafyddLlyr @jessicamcinchak @ianjon3s