feat: fetching team_settings data from database and populating forms #3319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RODO94
changed the title
RODO94
force-pushed
the
rory/team-settings-data-fetch
branch
from
5a52e40 to
0f171d6
Compare
RODO94
changed the title
RODO94
force-pushed
the
rory/team-settings-data-fetch
branch
from
779b520 to
f298693
Compare
RODO94
force-pushed
the
rory/team-settings-data-fetch
branch
from
f298693 to
f1c70fc
Compare
DafyddLlyr
reviewed
Jul 3, 2024
There was a problem hiding this comment.
The changes in this file (removed commas) don't match our linting style. Husky should be picking this up and fixing it as part of a pre-commit hook but this clearly isn't working right atm for your setup it seems. We can also look at checking this at the CI stage if we need to.
You can fix this file with pnpm lint:fix
|
PR Closed as overlapping changes became too tangled, changes have been moved to fresh branch: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Continuing work on the
team_settingsimplementation, this PR pulls in data from the database with a graphQL query and populates the corresponding form inputs.This PR also uses the update mutation, similar to
team_themesto update the form fields and database.This PR aligns with a planx-core change where the requests and types for a Team were altered to incorporate the new
team_settingstable.Reference to the planx-core changes