-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fetching team_settings data from database and populating forms #3319
Closed
Closed
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ecc4184
add new planx-core ref and fetched values to form inputs
RODO94 0509d4a
add update general settings to store and forms
RODO94 f1c70fc
remove comment out of general settings inherited from main
RODO94 dd47877
import input and input label
RODO94 140baa7
adjust store settings
RODO94 54964dc
chore: Only open dependabot PRs for major versions (#3361)
DafyddLlyr 85b8164
Revert "adjust store settings"
RODO94 c6b5de3
Merge branch 'main' into rory/team-settings-data-fetch
RODO94 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -85,7 +85,7 @@ describe("Header Component - Editor Route", () => { | |
id: 123, | ||
email: "[email protected]", | ||
}, | ||
}), | ||
}) | ||
); | ||
|
||
jest.spyOn(ReactNavi, "useCurrentRoute").mockImplementation( | ||
|
@@ -98,7 +98,7 @@ describe("Header Component - Editor Route", () => { | |
data: { | ||
flow: "test-flow", | ||
}, | ||
}) as any, | ||
}) as any | ||
); | ||
}); | ||
|
||
|
@@ -139,7 +139,7 @@ for (const route of ["/published", "/preview", "/draft", "/pay", "/invite"]) { | |
data: { | ||
flow: "test-flow", | ||
}, | ||
}) as any, | ||
}) as any | ||
); | ||
}); | ||
|
||
|
@@ -148,15 +148,15 @@ for (const route of ["/published", "/preview", "/draft", "/pay", "/invite"]) { | |
expect(screen.queryByText("Plan✕")).not.toBeInTheDocument(); | ||
expect(screen.getByAltText(`${mockTeam1.name} Logo`)).toHaveAttribute( | ||
"src", | ||
"logo.jpg", | ||
"logo.jpg" | ||
); | ||
}); | ||
|
||
it("falls back to the PlanX link when a logo is not present", () => { | ||
act(() => setState({ teamTheme: mockTeam2.theme })); | ||
setup(<Header />); | ||
expect( | ||
screen.queryByAltText(`${mockTeam2.name} Logo`), | ||
screen.queryByAltText(`${mockTeam2.name} Logo`) | ||
).not.toBeInTheDocument(); | ||
expect(screen.getByText("Plan✕")).toBeInTheDocument(); | ||
act(() => setState({ teamTheme: mockTeam1.theme })); | ||
|
@@ -190,7 +190,7 @@ describe("Section navigation bar", () => { | |
data: { | ||
flow: "test-flow", | ||
}, | ||
}) as any, | ||
}) as any | ||
); | ||
}); | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in this file (removed commas) don't match our linting style. Husky should be picking this up and fixing it as part of a pre-commit hook but this clearly isn't working right atm for your setup it seems. We can also look at checking this at the CI stage if we need to.
You can fix this file with
pnpm lint:fix