-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: In-page editor navigation menus #3336
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed vultr server and associated DNS entries |
ianjon3s
force-pushed
the
ian/editor-navigation-menus
branch
2 times, most recently
from
July 3, 2024 08:32
e57d400
to
b793e7b
Compare
ianjon3s
force-pushed
the
ian/editor-navigation-menus
branch
from
July 9, 2024 11:11
514ca16
to
ba5def5
Compare
DafyddLlyr
force-pushed
the
ian/editor-navigation-menus
branch
from
July 11, 2024 14:24
c6ea914
to
d9ffda6
Compare
DafyddLlyr
force-pushed
the
ian/editor-navigation-menus
branch
from
July 12, 2024 09:42
d9ffda6
to
6f03ea0
Compare
DafyddLlyr
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're good to go here! 🙌
Thanks for all your help on this one @DafyddLlyr ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new component
EditorNavMenu
that is used at the root, team and flow levels to link to all settings and panel screens.The menu has an optional
compact
prop that minimises the menu to icons only and introduces tooltips in place of text labels, this is used in the flow editor screen and settings pages.Routes are initially defined at the component level.
Still to do:
isActive
class is passed correctly to active itemsSettings
component and routes #3409EditorNavMenu
items permission based #3418