Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Flow Name Duplicate Validation #3445

Merged
merged 3 commits into from
Jul 19, 2024
Merged

feat: Flow Name Duplicate Validation #3445

merged 3 commits into from
Jul 19, 2024

Conversation

RODO94
Copy link
Contributor

@RODO94 RODO94 commented Jul 19, 2024

What does this PR do?

Following work done on Team Name in #3441 to validate duplicate team names, the same logic has been carried into Flow Name.

Greater detail on the thinking behind the code is given in the previously mentioned PR, #3441.

Copy link

github-actions bot commented Jul 19, 2024

Removed vultr server and associated DNS entries

@RODO94 RODO94 requested a review from a team July 19, 2024 15:00
Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice & simple & works as expected for me! Big improvement from a silent fail 🙌

editor.planx.uk/src/pages/Team.tsx Outdated Show resolved Hide resolved
@RODO94 RODO94 merged commit 5382dbd into main Jul 19, 2024
12 checks passed
@RODO94 RODO94 deleted the rory/flow-name-validate branch July 19, 2024 15:35
@RODO94
Copy link
Contributor Author

RODO94 commented Jul 22, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants