Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(search): Search data fields for all component types #3476

Closed
wants to merge 1 commit into from
Closed

feat(search): Search data fields for all component types #3476

wants to merge 1 commit into from

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Jul 30, 2024 •
edited
Loading

To Do

  • Tests!
  • Better type for data variables in SearchNode.facets
  • Break up / clean up nested if conditions used to get prototype working

@DafyddLlyr DafyddLlyr mentioned this pull request Jul 30, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 30, 2024 •
edited
Loading

Pizza

Deployed e179231 to https://3476.planx.pizza.

Useful links:

@DafyddLlyr DafyddLlyr force-pushed the dp/search-all-data-fields branch from 51bb175 to 0648113 Compare August 7, 2024 16:10
@DafyddLlyr DafyddLlyr force-pushed the dp/search-all-data-fields branch from 0648113 to 2dbb322 Compare August 7, 2024 21:28
This was referenced Aug 26, 2024
Merged
Merged
@DafyddLlyr
Copy link
Contributor Author

Closed - replaced by #3576

@DafyddLlyr DafyddLlyr closed this Aug 27, 2024
@DafyddLlyr DafyddLlyr deleted the dp/search-all-data-fields branch August 27, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DafyddLlyr